Commit d6cb41cc authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds
Browse files

mm, hugetlb: remove hugepages_treat_as_movable sysctl 

hugepages_treat_as_movable has been introduced by 396faf03 ("Allow
huge page allocations to use GFP_HIGH_MOVABLE") to allow hugetlb
allocations from ZONE_MOVABLE even when hugetlb pages were not
migrateable.  The purpose of the movable zone was different at the time.
It aimed at reducing memory fragmentation and hugetlb pages being long
lived and large werre not contributing to the fragmentation so it was
acceptable to use the zone back then.

Things have changed though and the primary purpose of the zone became
migratability guarantee.  If we allow non migrateable hugetlb pages to
be in ZONE_MOVABLE memory hotplug might fail to offline the memory.

Remove the knob and only rely on hugepage_migration_supported to allow
movable zones.

Mel said:

: Primarily it was aimed at allowing the hugetlb pool to safely shrink with
: the ability to grow it again.  The use case was for batched jobs, some of
: which needed huge pages and others that did not but didn't want the memory
: useless pinned in the huge pages pool.
:
: I suspect that more users rely on THP than hugetlbfs for flexible use of
: huge pages with fallback options so I think that removing the option
: should be ok.

Link: http://lkml.kernel.org/r/20171003072619.8654-1-mhocko@kernel.org


Signed-off-by: default avatarMichal Hocko <mhocko@suse.com>
Reported-by: default avatarAlexandru Moise <00moses.alexander00@gmail.com>
Acked-by: default avatarMel Gorman <mgorman@suse.de>
Cc: Alexandru Moise <00moses.alexander00@gmail.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a4ef8768

Documentation/sysctl/vm.txt

+0 −25
Original line number Diff line number Diff line
@@ -30,7 +30,6 @@ Currently, these files are in /proc/sys/vm: 
- dirty_writeback_centisecs

- drop_caches

- extfrag_threshold

- hugepages_treat_as_movable

- hugetlb_shm_group

- laptop_mode

- legacy_va_layout
@@ -261,30 +260,6 @@ any throttling. 


==============================================================



hugepages_treat_as_movable



This parameter controls whether we can allocate hugepages from ZONE_MOVABLE

or not. If set to non-zero, hugepages can be allocated from ZONE_MOVABLE.

ZONE_MOVABLE is created when kernel boot parameter kernelcore= is specified,

so this parameter has no effect if used without kernelcore=.



Hugepage migration is now available in some situations which depend on the

architecture and/or the hugepage size. If a hugepage supports migration,

allocation from ZONE_MOVABLE is always enabled for the hugepage regardless

of the value of this parameter.

IOW, this parameter affects only non-migratable hugepages.



Assuming that hugepages are not migratable in your system, one usecase of

this parameter is that users can make hugepage pool more extensible by

enabling the allocation from ZONE_MOVABLE. This is because on ZONE_MOVABLE

page reclaim/migration/compaction work more and you can get contiguous

memory more likely. Note that using ZONE_MOVABLE for non-migratable

hugepages can do harm to other features like memory hotremove (because

memory hotremove expects that memory blocks on ZONE_MOVABLE are always

removable,) so it's a trade-off responsible for the users.



==============================================================



hugetlb_shm_group



hugetlb_shm_group contains group id that is allowed to create SysV

include/linux/hugetlb.h

+0 −1
Original line number Diff line number Diff line
@@ -129,7 +129,6 @@ u32 hugetlb_fault_mutex_hash(struct hstate *h, struct mm_struct *mm, 


pte_t *huge_pmd_share(struct mm_struct *mm, unsigned long addr, pud_t *pud);



extern int hugepages_treat_as_movable;

extern int sysctl_hugetlb_shm_group;

extern struct list_head huge_boot_pages;

kernel/sysctl.c

+0 −7
Original line number Diff line number Diff line
@@ -1374,13 +1374,6 @@ static struct ctl_table vm_table[] = { 
		.mode		= 0644,

		.proc_handler	= proc_dointvec,

	 },

	 {

		.procname	= "hugepages_treat_as_movable",

		.data		= &hugepages_treat_as_movable,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		.proc_handler	= proc_dointvec,

	},

	{

		.procname	= "nr_overcommit_hugepages",

		.data		= NULL,

mm/hugetlb.c

+1 −3
Original line number Diff line number Diff line
@@ -36,8 +36,6 @@ 
#include <linux/userfaultfd_k.h>

#include "internal.h"



int hugepages_treat_as_movable;



int hugetlb_max_hstate __read_mostly;

unsigned int default_hstate_idx;

struct hstate hstates[HUGE_MAX_HSTATE];
@@ -926,7 +924,7 @@ retry_cpuset: 
/* Movability of hugepages depends on migration support. */

static inline gfp_t htlb_alloc_mask(struct hstate *h)

{

	if (hugepages_treat_as_movable || hugepage_migration_supported(h))

	if (hugepage_migration_supported(h))

		return GFP_HIGHUSER_MOVABLE;

	else

		return GFP_HIGHUSER;

CRA Git | Maintained and supported by SUSTech CRA and CCSE