Commit d6bc34c5 authored Feb 14, 2020 by Adrian Hunter Committed by Arnaldo Carvalho de Melo Feb 18, 2020

perf arm-spe: Fix endless record after being terminated



In __cmd_record(), when receiving SIGINT(ctrl + c), a 'done' flag will
be set and the event list will be disabled by evlist__disable() once.

While in auxtrace_record.read_finish(), the related events will be
enabled again, if they are continuous, the recording seems to be
endless.

If the event is disabled, don't enable it again here.

Based-on-patch-by: Wei Li <liwei391@huawei.com>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Tan Xiaojun <tanxiaojun@huawei.com>
Cc: stable@vger.kernel.org # 5.4+
Link: http://lore.kernel.org/lkml/20200214132654.20395-5-adrian.hunter@intel.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent c9f2833c

tools/perf/arch/arm64/util/arm-spe.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -165,10 +165,13 @@ static int arm_spe_read_finish(struct auxtrace_record *itr, int idx)
		struct evsel *evsel;

		evlist__for_each_entry(sper->evlist, evsel) {
		if (evsel->core.attr.type == sper->arm_spe_pmu->type)
		if (evsel->core.attr.type == sper->arm_spe_pmu->type) {
		if (evsel->disabled)
		return 0;
		return perf_evlist__enable_event_idx(sper->evlist,
		evsel, idx);
		}
		}
		return -EINVAL;
		}

Admin message