Commit d6a6af2c authored Dec 08, 2014 by Ian Munsie Committed by Michael Ellerman Dec 29, 2014

cxl: Disable AFU debug flag



Upon inspection of the implementation specific registers, it was
discovered that the high bit of the implementation specific RXCTL
register was enabled, which enables the DEADB00F debug feature.

The debug feature causes MMIO reads to a disabled AFU to respond with
0xDEADB00F instead of all Fs. In general this should not be visible as
the kernel will only allow MMIO access to enabled AFUs, but there may be
some circumstances where an AFU may become disabled while it is use.
One such case would be an AFU designed to only be used in the dedicated
process mode and to disable itself after it has completed it's work
(however even in that case the effects of this debug flag would be
limited as the userspace application must have completed any required
MMIO accesses before the AFU disables itself with or without the flag).

This patch removes the debug flag and replaces the magic value
programmed into this register with a preprocessor define so it is
clearer what the rest of this initialisation does.

Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 13da7046

drivers/misc/cxl/cxl.h

+7 −0

Original line number	Diff line number	Diff line
		@@ -287,6 +287,13 @@ static const cxl_p2n_reg_t CXL_PSL_WED_An = {0x0A0};
		#define CXL_PE_SOFTWARE_STATE_S (1ul << (31 - 30)) /* Suspend */
		#define CXL_PE_SOFTWARE_STATE_T (1ul << (31 - 31)) /* Terminate */

		/**** CXL_PSL_RXCTL_An (Implementation Specific) ************************
		* Controls AFU Hang Pulse, which sets the timeout for the AFU to respond to
		* the PSL for any response (except MMIO). Timeouts will occur between 1x to 2x
		* of the hang pulse frequency.
		*/
		#define CXL_PSL_RXCTL_AFUHP_4S 0x7000000000000000ULL

		/* SPA->sw_command_status */
		#define CXL_SPA_SW_CMD_MASK 0xffff000000000000ULL
		#define CXL_SPA_SW_CMD_TERMINATE 0x0001000000000000ULL

drivers/misc/cxl/pci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -348,7 +348,7 @@ static int init_implementation_afu_regs(struct cxl_afu *afu)
		cxl_p1n_write(afu, CXL_PSL_COALLOC_A, 0xFF000000FEFEFEFEULL);
		/* for debugging with trace arrays */
		cxl_p1n_write(afu, CXL_PSL_SLICE_TRACE, 0x0000FFFF00000000ULL);
		cxl_p1n_write(afu, CXL_PSL_RXCTL_A, 0xF000000000000000ULL);
		cxl_p1n_write(afu, CXL_PSL_RXCTL_A, CXL_PSL_RXCTL_AFUHP_4S);

		return 0;
		}

Admin message