Commit d69b9c38 authored Nov 10, 2017 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Nov 27, 2017

staging: speakup: selection: replace _manual_ swap with swap macro



Make use of the swap macro instead of _manually_ swapping values
and remove unnecessary variable tmp.

This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f6829ad6

drivers/staging/speakup/selection.c

+2 −7

Original line number	Diff line number	Diff line
		@@ -64,13 +64,8 @@ int speakup_set_selection(struct tty_struct *tty)
		ps = spk_ys * vc->vc_size_row + (spk_xs << 1);
		pe = spk_ye * vc->vc_size_row + (spk_xe << 1);

		if (ps > pe) {
		/* make sel_start <= sel_end */
		int tmp = ps;

		ps = pe;
		pe = tmp;
		}
		if (ps > pe) /* make sel_start <= sel_end */
		swap(ps, pe);

		if (spk_sel_cons != vc_cons[fg_console].d) {
		speakup_clear_selection();

Admin message