Commit d6834770 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi 

Pull SCSI fixes from James Bottomley:
 "A couple of major (hang and deadlock) fixes with fortunately fairly
  rare triggering conditions.  The PM oops is only really triggered by
  people using enclosure services (rare) and the fnic driver is mostly
  used in enterprise environments"

* tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
  SCSI: Fix NULL pointer dereference in runtime PM
  fnic: Use the local variable instead of I/O flag to acquire io_req_lock in fnic_queuecommand() to avoid deadloack
parents eb63b34b 49718f0f

drivers/scsi/fnic/fnic.h

+1 −1
Original line number Diff line number Diff line
@@ -39,7 +39,7 @@ 


#define DRV_NAME		"fnic"

#define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"

#define DRV_VERSION		"1.6.0.17"

#define DRV_VERSION		"1.6.0.17a"

#define PFX			DRV_NAME ": "

#define DFX                     DRV_NAME "%d: "

drivers/scsi/fnic/fnic_scsi.c

+3 −1
Original line number Diff line number Diff line
@@ -425,6 +425,7 @@ static int fnic_queuecommand_lck(struct scsi_cmnd *sc, void (*done)(struct scsi_ 
	unsigned long ptr;

	struct fc_rport_priv *rdata;

	spinlock_t *io_lock = NULL;

	int io_lock_acquired = 0;



	if (unlikely(fnic_chk_state_flags_locked(fnic, FNIC_FLAGS_IO_BLOCKED)))

		return SCSI_MLQUEUE_HOST_BUSY;
@@ -518,6 +519,7 @@ static int fnic_queuecommand_lck(struct scsi_cmnd *sc, void (*done)(struct scsi_ 
	spin_lock_irqsave(io_lock, flags);



	/* initialize rest of io_req */

	io_lock_acquired = 1;

	io_req->port_id = rport->port_id;

	io_req->start_time = jiffies;

	CMD_STATE(sc) = FNIC_IOREQ_CMD_PENDING;
@@ -571,7 +573,7 @@ out: 
		  (((u64)CMD_FLAGS(sc) >> 32) | CMD_STATE(sc)));



	/* if only we issued IO, will we have the io lock */

	if (CMD_FLAGS(sc) & FNIC_IO_INITIALIZED)

	if (io_lock_acquired)

		spin_unlock_irqrestore(io_lock, flags);



	atomic_dec(&fnic->in_flight);

drivers/scsi/scsi_pm.c

+11 −11
Original line number Diff line number Diff line
@@ -217,15 +217,15 @@ static int sdev_runtime_suspend(struct device *dev) 
{

	const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;

	struct scsi_device *sdev = to_scsi_device(dev);

	int err;

	int err = 0;



	if (pm && pm->runtime_suspend) {

		err = blk_pre_runtime_suspend(sdev->request_queue);

		if (err)

			return err;

	if (pm && pm->runtime_suspend)

		err = pm->runtime_suspend(dev);

		blk_post_runtime_suspend(sdev->request_queue, err);



	}

	return err;

}
@@ -248,11 +248,11 @@ static int sdev_runtime_resume(struct device *dev) 
	const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL;

	int err = 0;



	if (pm && pm->runtime_resume) {

		blk_pre_runtime_resume(sdev->request_queue);

	if (pm && pm->runtime_resume)

		err = pm->runtime_resume(dev);

		blk_post_runtime_resume(sdev->request_queue, err);



	}

	return err;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE