Commit d671fa63 authored Nov 11, 2019 by Hewenliang Committed by Tejun Heo Nov 12, 2019

kselftests: cgroup: Avoid the reuse of fd after it is deallocated



It is necessary to set fd to -1 when inotify_add_watch() fails in
cg_prepare_for_wait. Otherwise the fd which has been closed in
cg_prepare_for_wait may be misused in other functions such as
cg_enter_and_wait_for_frozen and cg_freeze_wait.

Fixes: 5313bfe4 ("selftests: cgroup: add freezer controller self-tests")
Signed-off-by: Hewenliang <hewenliang4@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 742e8cd3

tools/testing/selftests/cgroup/test_freezer.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -72,6 +72,7 @@ static int cg_prepare_for_wait(const char *cgroup)
		if (ret == -1) {
		debug("Error: inotify_add_watch() failed\n");
		close(fd);
		fd = -1;
		}

		return fd;

Admin message