Commit d661684c authored Aug 22, 2013 by Andy Lutomirski Committed by David S. Miller Aug 27, 2013

net: Check the correct namespace when spoofing pid over SCM_RIGHTS



This is a security bug.

The follow-up will fix nsproxy to discourage this type of issue from
happening again.

Cc: stable@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent dd5746bf

net/core/scm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -54,7 +54,7 @@ static __inline__ int scm_check_creds(struct ucred *creds)
		return -EINVAL;

		if ((creds->pid == task_tgid_vnr(current) \|\|
		ns_capable(current->nsproxy->pid_ns->user_ns, CAP_SYS_ADMIN)) &&
		ns_capable(task_active_pid_ns(current)->user_ns, CAP_SYS_ADMIN)) &&
		((uid_eq(uid, cred->uid) \|\| uid_eq(uid, cred->euid) \|\|
		uid_eq(uid, cred->suid)) \|\| nsown_capable(CAP_SETUID)) &&
		((gid_eq(gid, cred->gid) \|\| gid_eq(gid, cred->egid) \|\|

Admin message