Commit d65eba6a authored Apr 12, 2013 by Yijing Wang Committed by Bjorn Helgaas Apr 12, 2013

PCI: acpiphp: Use list_for_each_entry_safe() in acpiphp_sanitize_bus()



Function acpiphp_sanitize_bus() may call pci_stop_and_remove_bus_device(),
which in turn may remove device from bus->devices list. So walk the
bus->devices list with list_for_each_entry_safe().

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Yinghai Lu <yinghai@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Toshi Kani <toshi.kani@hp.com>

parent 981cf9ea

drivers/pci/hotplug/acpiphp_glue.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1082,11 +1082,11 @@ static void acpiphp_set_hpp_values(struct pci_bus *bus)
		*/
		static void acpiphp_sanitize_bus(struct pci_bus *bus)
		{
		struct pci_dev *dev;
		struct pci_dev dev, tmp;
		int i;
		unsigned long type_mask = IORESOURCE_IO \| IORESOURCE_MEM;

		list_for_each_entry(dev, &bus->devices, bus_list) {
		list_for_each_entry_safe(dev, tmp, &bus->devices, bus_list) {
		for (i=0; i<PCI_BRIDGE_RESOURCES; i++) {
		struct resource *res = &dev->resource[i];
		if ((res->flags & type_mask) && !res->start &&

Admin message