Commit d646a02a authored Feb 21, 2013 by Guo Chao Committed by Jens Axboe Feb 22, 2013

block: use i_size_write() in bd_set_size()

blkdev_ioctl(GETBLKSIZE) uses i_size_read() to read size of block device.
If we update block size directly, reader may see intermediate result in
some machines and configurations.  Use i_size_write() instead.

Signed-off-by: Guo Chao <yan@linux.vnet.ibm.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Guo Chao <yan@linux.vnet.ibm.com>
Cc: M. Hindess <hindessm@uk.ibm.com>
Cc: Nikanth Karthikesan <knikanth@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent a3cc86c2

fs/block_dev.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1032,7 +1032,9 @@ void bd_set_size(struct block_device *bdev, loff_t size)
		{
		unsigned bsize = bdev_logical_block_size(bdev);

		bdev->bd_inode->i_size = size;
		mutex_lock(&bdev->bd_inode->i_mutex);
		i_size_write(bdev->bd_inode, size);
		mutex_unlock(&bdev->bd_inode->i_mutex);
		while (bsize < PAGE_CACHE_SIZE) {
		if (size & bsize)
		break;

Admin message