Commit d61e4038 authored by Joe Perches's avatar Joe Perches Committed by David S. Miller
Browse files

drivers/net: Use octal not symbolic permissions



Prefer the direct use of octal for permissions.

Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace
and some typing.

Miscellanea:

o Whitespace neatening around these conversions.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarWei Liu <wei.liu2@citrix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d6444062
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -287,7 +287,7 @@ void bond_create_proc_entry(struct bonding *bond)


	if (bn->proc_dir) {
	if (bn->proc_dir) {
		bond->proc_entry = proc_create_data(bond_dev->name,
		bond->proc_entry = proc_create_data(bond_dev->name,
						    S_IRUGO, bn->proc_dir,
						    0444, bn->proc_dir,
						    &bond_info_fops, bond);
						    &bond_info_fops, bond);
		if (bond->proc_entry == NULL)
		if (bond->proc_entry == NULL)
			netdev_warn(bond_dev, "Cannot create /proc/net/%s/%s\n",
			netdev_warn(bond_dev, "Cannot create /proc/net/%s/%s\n",
+36 −37
Original line number Original line Diff line number Diff line
@@ -147,7 +147,7 @@ err_no_cmd:
static const struct class_attribute class_attr_bonding_masters = {
static const struct class_attribute class_attr_bonding_masters = {
	.attr = {
	.attr = {
		.name = "bonding_masters",
		.name = "bonding_masters",
		.mode = S_IWUSR | S_IRUGO,
		.mode = 0644,
	},
	},
	.show = bonding_show_bonds,
	.show = bonding_show_bonds,
	.store = bonding_store_bonds,
	.store = bonding_store_bonds,
@@ -202,7 +202,7 @@ static ssize_t bonding_show_slaves(struct device *d,


	return res;
	return res;
}
}
static DEVICE_ATTR(slaves, S_IRUGO | S_IWUSR, bonding_show_slaves,
static DEVICE_ATTR(slaves, 0644, bonding_show_slaves,
		   bonding_sysfs_store_option);
		   bonding_sysfs_store_option);


/* Show the bonding mode. */
/* Show the bonding mode. */
@@ -216,8 +216,7 @@ static ssize_t bonding_show_mode(struct device *d,


	return sprintf(buf, "%s %d\n", val->string, BOND_MODE(bond));
	return sprintf(buf, "%s %d\n", val->string, BOND_MODE(bond));
}
}
static DEVICE_ATTR(mode, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(mode, 0644, bonding_show_mode, bonding_sysfs_store_option);
		   bonding_show_mode, bonding_sysfs_store_option);


/* Show the bonding transmit hash method. */
/* Show the bonding transmit hash method. */
static ssize_t bonding_show_xmit_hash(struct device *d,
static ssize_t bonding_show_xmit_hash(struct device *d,
@@ -231,7 +230,7 @@ static ssize_t bonding_show_xmit_hash(struct device *d,


	return sprintf(buf, "%s %d\n", val->string, bond->params.xmit_policy);
	return sprintf(buf, "%s %d\n", val->string, bond->params.xmit_policy);
}
}
static DEVICE_ATTR(xmit_hash_policy, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(xmit_hash_policy, 0644,
		   bonding_show_xmit_hash, bonding_sysfs_store_option);
		   bonding_show_xmit_hash, bonding_sysfs_store_option);


/* Show arp_validate. */
/* Show arp_validate. */
@@ -247,7 +246,7 @@ static ssize_t bonding_show_arp_validate(struct device *d,


	return sprintf(buf, "%s %d\n", val->string, bond->params.arp_validate);
	return sprintf(buf, "%s %d\n", val->string, bond->params.arp_validate);
}
}
static DEVICE_ATTR(arp_validate, S_IRUGO | S_IWUSR, bonding_show_arp_validate,
static DEVICE_ATTR(arp_validate, 0644, bonding_show_arp_validate,
		   bonding_sysfs_store_option);
		   bonding_sysfs_store_option);


/* Show arp_all_targets. */
/* Show arp_all_targets. */
@@ -263,7 +262,7 @@ static ssize_t bonding_show_arp_all_targets(struct device *d,
	return sprintf(buf, "%s %d\n",
	return sprintf(buf, "%s %d\n",
		       val->string, bond->params.arp_all_targets);
		       val->string, bond->params.arp_all_targets);
}
}
static DEVICE_ATTR(arp_all_targets, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(arp_all_targets, 0644,
		   bonding_show_arp_all_targets, bonding_sysfs_store_option);
		   bonding_show_arp_all_targets, bonding_sysfs_store_option);


/* Show fail_over_mac. */
/* Show fail_over_mac. */
@@ -279,7 +278,7 @@ static ssize_t bonding_show_fail_over_mac(struct device *d,


	return sprintf(buf, "%s %d\n", val->string, bond->params.fail_over_mac);
	return sprintf(buf, "%s %d\n", val->string, bond->params.fail_over_mac);
}
}
static DEVICE_ATTR(fail_over_mac, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(fail_over_mac, 0644,
		   bonding_show_fail_over_mac, bonding_sysfs_store_option);
		   bonding_show_fail_over_mac, bonding_sysfs_store_option);


/* Show the arp timer interval. */
/* Show the arp timer interval. */
@@ -291,7 +290,7 @@ static ssize_t bonding_show_arp_interval(struct device *d,


	return sprintf(buf, "%d\n", bond->params.arp_interval);
	return sprintf(buf, "%d\n", bond->params.arp_interval);
}
}
static DEVICE_ATTR(arp_interval, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(arp_interval, 0644,
		   bonding_show_arp_interval, bonding_sysfs_store_option);
		   bonding_show_arp_interval, bonding_sysfs_store_option);


/* Show the arp targets. */
/* Show the arp targets. */
@@ -312,7 +311,7 @@ static ssize_t bonding_show_arp_targets(struct device *d,


	return res;
	return res;
}
}
static DEVICE_ATTR(arp_ip_target, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(arp_ip_target, 0644,
		   bonding_show_arp_targets, bonding_sysfs_store_option);
		   bonding_show_arp_targets, bonding_sysfs_store_option);


/* Show the up and down delays. */
/* Show the up and down delays. */
@@ -324,7 +323,7 @@ static ssize_t bonding_show_downdelay(struct device *d,


	return sprintf(buf, "%d\n", bond->params.downdelay * bond->params.miimon);
	return sprintf(buf, "%d\n", bond->params.downdelay * bond->params.miimon);
}
}
static DEVICE_ATTR(downdelay, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(downdelay, 0644,
		   bonding_show_downdelay, bonding_sysfs_store_option);
		   bonding_show_downdelay, bonding_sysfs_store_option);


static ssize_t bonding_show_updelay(struct device *d,
static ssize_t bonding_show_updelay(struct device *d,
@@ -336,7 +335,7 @@ static ssize_t bonding_show_updelay(struct device *d,
	return sprintf(buf, "%d\n", bond->params.updelay * bond->params.miimon);
	return sprintf(buf, "%d\n", bond->params.updelay * bond->params.miimon);


}
}
static DEVICE_ATTR(updelay, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(updelay, 0644,
		   bonding_show_updelay, bonding_sysfs_store_option);
		   bonding_show_updelay, bonding_sysfs_store_option);


/* Show the LACP interval. */
/* Show the LACP interval. */
@@ -351,7 +350,7 @@ static ssize_t bonding_show_lacp(struct device *d,


	return sprintf(buf, "%s %d\n", val->string, bond->params.lacp_fast);
	return sprintf(buf, "%s %d\n", val->string, bond->params.lacp_fast);
}
}
static DEVICE_ATTR(lacp_rate, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(lacp_rate, 0644,
		   bonding_show_lacp, bonding_sysfs_store_option);
		   bonding_show_lacp, bonding_sysfs_store_option);


static ssize_t bonding_show_min_links(struct device *d,
static ssize_t bonding_show_min_links(struct device *d,
@@ -362,7 +361,7 @@ static ssize_t bonding_show_min_links(struct device *d,


	return sprintf(buf, "%u\n", bond->params.min_links);
	return sprintf(buf, "%u\n", bond->params.min_links);
}
}
static DEVICE_ATTR(min_links, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(min_links, 0644,
		   bonding_show_min_links, bonding_sysfs_store_option);
		   bonding_show_min_links, bonding_sysfs_store_option);


static ssize_t bonding_show_ad_select(struct device *d,
static ssize_t bonding_show_ad_select(struct device *d,
@@ -376,7 +375,7 @@ static ssize_t bonding_show_ad_select(struct device *d,


	return sprintf(buf, "%s %d\n", val->string, bond->params.ad_select);
	return sprintf(buf, "%s %d\n", val->string, bond->params.ad_select);
}
}
static DEVICE_ATTR(ad_select, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(ad_select, 0644,
		   bonding_show_ad_select, bonding_sysfs_store_option);
		   bonding_show_ad_select, bonding_sysfs_store_option);


/* Show the number of peer notifications to send after a failover event. */
/* Show the number of peer notifications to send after a failover event. */
@@ -387,9 +386,9 @@ static ssize_t bonding_show_num_peer_notif(struct device *d,
	struct bonding *bond = to_bond(d);
	struct bonding *bond = to_bond(d);
	return sprintf(buf, "%d\n", bond->params.num_peer_notif);
	return sprintf(buf, "%d\n", bond->params.num_peer_notif);
}
}
static DEVICE_ATTR(num_grat_arp, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(num_grat_arp, 0644,
		   bonding_show_num_peer_notif, bonding_sysfs_store_option);
		   bonding_show_num_peer_notif, bonding_sysfs_store_option);
static DEVICE_ATTR(num_unsol_na, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(num_unsol_na, 0644,
		   bonding_show_num_peer_notif, bonding_sysfs_store_option);
		   bonding_show_num_peer_notif, bonding_sysfs_store_option);


/* Show the MII monitor interval. */
/* Show the MII monitor interval. */
@@ -401,7 +400,7 @@ static ssize_t bonding_show_miimon(struct device *d,


	return sprintf(buf, "%d\n", bond->params.miimon);
	return sprintf(buf, "%d\n", bond->params.miimon);
}
}
static DEVICE_ATTR(miimon, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(miimon, 0644,
		   bonding_show_miimon, bonding_sysfs_store_option);
		   bonding_show_miimon, bonding_sysfs_store_option);


/* Show the primary slave. */
/* Show the primary slave. */
@@ -421,7 +420,7 @@ static ssize_t bonding_show_primary(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(primary, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(primary, 0644,
		   bonding_show_primary, bonding_sysfs_store_option);
		   bonding_show_primary, bonding_sysfs_store_option);


/* Show the primary_reselect flag. */
/* Show the primary_reselect flag. */
@@ -438,7 +437,7 @@ static ssize_t bonding_show_primary_reselect(struct device *d,
	return sprintf(buf, "%s %d\n",
	return sprintf(buf, "%s %d\n",
		       val->string, bond->params.primary_reselect);
		       val->string, bond->params.primary_reselect);
}
}
static DEVICE_ATTR(primary_reselect, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(primary_reselect, 0644,
		   bonding_show_primary_reselect, bonding_sysfs_store_option);
		   bonding_show_primary_reselect, bonding_sysfs_store_option);


/* Show the use_carrier flag. */
/* Show the use_carrier flag. */
@@ -450,7 +449,7 @@ static ssize_t bonding_show_carrier(struct device *d,


	return sprintf(buf, "%d\n", bond->params.use_carrier);
	return sprintf(buf, "%d\n", bond->params.use_carrier);
}
}
static DEVICE_ATTR(use_carrier, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(use_carrier, 0644,
		   bonding_show_carrier, bonding_sysfs_store_option);
		   bonding_show_carrier, bonding_sysfs_store_option);




@@ -471,7 +470,7 @@ static ssize_t bonding_show_active_slave(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(active_slave, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(active_slave, 0644,
		   bonding_show_active_slave, bonding_sysfs_store_option);
		   bonding_show_active_slave, bonding_sysfs_store_option);


/* Show link status of the bond interface. */
/* Show link status of the bond interface. */
@@ -484,7 +483,7 @@ static ssize_t bonding_show_mii_status(struct device *d,


	return sprintf(buf, "%s\n", active ? "up" : "down");
	return sprintf(buf, "%s\n", active ? "up" : "down");
}
}
static DEVICE_ATTR(mii_status, S_IRUGO, bonding_show_mii_status, NULL);
static DEVICE_ATTR(mii_status, 0444, bonding_show_mii_status, NULL);


/* Show current 802.3ad aggregator ID. */
/* Show current 802.3ad aggregator ID. */
static ssize_t bonding_show_ad_aggregator(struct device *d,
static ssize_t bonding_show_ad_aggregator(struct device *d,
@@ -503,7 +502,7 @@ static ssize_t bonding_show_ad_aggregator(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(ad_aggregator, S_IRUGO, bonding_show_ad_aggregator, NULL);
static DEVICE_ATTR(ad_aggregator, 0444, bonding_show_ad_aggregator, NULL);




/* Show number of active 802.3ad ports. */
/* Show number of active 802.3ad ports. */
@@ -523,7 +522,7 @@ static ssize_t bonding_show_ad_num_ports(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(ad_num_ports, S_IRUGO, bonding_show_ad_num_ports, NULL);
static DEVICE_ATTR(ad_num_ports, 0444, bonding_show_ad_num_ports, NULL);




/* Show current 802.3ad actor key. */
/* Show current 802.3ad actor key. */
@@ -543,7 +542,7 @@ static ssize_t bonding_show_ad_actor_key(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(ad_actor_key, S_IRUGO, bonding_show_ad_actor_key, NULL);
static DEVICE_ATTR(ad_actor_key, 0444, bonding_show_ad_actor_key, NULL);




/* Show current 802.3ad partner key. */
/* Show current 802.3ad partner key. */
@@ -563,7 +562,7 @@ static ssize_t bonding_show_ad_partner_key(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(ad_partner_key, S_IRUGO, bonding_show_ad_partner_key, NULL);
static DEVICE_ATTR(ad_partner_key, 0444, bonding_show_ad_partner_key, NULL);




/* Show current 802.3ad partner mac. */
/* Show current 802.3ad partner mac. */
@@ -582,7 +581,7 @@ static ssize_t bonding_show_ad_partner_mac(struct device *d,


	return count;
	return count;
}
}
static DEVICE_ATTR(ad_partner_mac, S_IRUGO, bonding_show_ad_partner_mac, NULL);
static DEVICE_ATTR(ad_partner_mac, 0444, bonding_show_ad_partner_mac, NULL);


/* Show the queue_ids of the slaves in the current bond. */
/* Show the queue_ids of the slaves in the current bond. */
static ssize_t bonding_show_queue_id(struct device *d,
static ssize_t bonding_show_queue_id(struct device *d,
@@ -615,7 +614,7 @@ static ssize_t bonding_show_queue_id(struct device *d,


	return res;
	return res;
}
}
static DEVICE_ATTR(queue_id, S_IRUGO | S_IWUSR, bonding_show_queue_id,
static DEVICE_ATTR(queue_id, 0644, bonding_show_queue_id,
		   bonding_sysfs_store_option);
		   bonding_sysfs_store_option);




@@ -628,7 +627,7 @@ static ssize_t bonding_show_slaves_active(struct device *d,


	return sprintf(buf, "%d\n", bond->params.all_slaves_active);
	return sprintf(buf, "%d\n", bond->params.all_slaves_active);
}
}
static DEVICE_ATTR(all_slaves_active, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(all_slaves_active, 0644,
		   bonding_show_slaves_active, bonding_sysfs_store_option);
		   bonding_show_slaves_active, bonding_sysfs_store_option);


/* Show the number of IGMP membership reports to send on link failure */
/* Show the number of IGMP membership reports to send on link failure */
@@ -640,7 +639,7 @@ static ssize_t bonding_show_resend_igmp(struct device *d,


	return sprintf(buf, "%d\n", bond->params.resend_igmp);
	return sprintf(buf, "%d\n", bond->params.resend_igmp);
}
}
static DEVICE_ATTR(resend_igmp, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(resend_igmp, 0644,
		   bonding_show_resend_igmp, bonding_sysfs_store_option);
		   bonding_show_resend_igmp, bonding_sysfs_store_option);




@@ -652,7 +651,7 @@ static ssize_t bonding_show_lp_interval(struct device *d,


	return sprintf(buf, "%d\n", bond->params.lp_interval);
	return sprintf(buf, "%d\n", bond->params.lp_interval);
}
}
static DEVICE_ATTR(lp_interval, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(lp_interval, 0644,
		   bonding_show_lp_interval, bonding_sysfs_store_option);
		   bonding_show_lp_interval, bonding_sysfs_store_option);


static ssize_t bonding_show_tlb_dynamic_lb(struct device *d,
static ssize_t bonding_show_tlb_dynamic_lb(struct device *d,
@@ -662,7 +661,7 @@ static ssize_t bonding_show_tlb_dynamic_lb(struct device *d,
	struct bonding *bond = to_bond(d);
	struct bonding *bond = to_bond(d);
	return sprintf(buf, "%d\n", bond->params.tlb_dynamic_lb);
	return sprintf(buf, "%d\n", bond->params.tlb_dynamic_lb);
}
}
static DEVICE_ATTR(tlb_dynamic_lb, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(tlb_dynamic_lb, 0644,
		   bonding_show_tlb_dynamic_lb, bonding_sysfs_store_option);
		   bonding_show_tlb_dynamic_lb, bonding_sysfs_store_option);


static ssize_t bonding_show_packets_per_slave(struct device *d,
static ssize_t bonding_show_packets_per_slave(struct device *d,
@@ -674,7 +673,7 @@ static ssize_t bonding_show_packets_per_slave(struct device *d,


	return sprintf(buf, "%u\n", packets_per_slave);
	return sprintf(buf, "%u\n", packets_per_slave);
}
}
static DEVICE_ATTR(packets_per_slave, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(packets_per_slave, 0644,
		   bonding_show_packets_per_slave, bonding_sysfs_store_option);
		   bonding_show_packets_per_slave, bonding_sysfs_store_option);


static ssize_t bonding_show_ad_actor_sys_prio(struct device *d,
static ssize_t bonding_show_ad_actor_sys_prio(struct device *d,
@@ -688,7 +687,7 @@ static ssize_t bonding_show_ad_actor_sys_prio(struct device *d,


	return 0;
	return 0;
}
}
static DEVICE_ATTR(ad_actor_sys_prio, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(ad_actor_sys_prio, 0644,
		   bonding_show_ad_actor_sys_prio, bonding_sysfs_store_option);
		   bonding_show_ad_actor_sys_prio, bonding_sysfs_store_option);


static ssize_t bonding_show_ad_actor_system(struct device *d,
static ssize_t bonding_show_ad_actor_system(struct device *d,
@@ -703,7 +702,7 @@ static ssize_t bonding_show_ad_actor_system(struct device *d,
	return 0;
	return 0;
}
}


static DEVICE_ATTR(ad_actor_system, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(ad_actor_system, 0644,
		   bonding_show_ad_actor_system, bonding_sysfs_store_option);
		   bonding_show_ad_actor_system, bonding_sysfs_store_option);


static ssize_t bonding_show_ad_user_port_key(struct device *d,
static ssize_t bonding_show_ad_user_port_key(struct device *d,
@@ -717,7 +716,7 @@ static ssize_t bonding_show_ad_user_port_key(struct device *d,


	return 0;
	return 0;
}
}
static DEVICE_ATTR(ad_user_port_key, S_IRUGO | S_IWUSR,
static DEVICE_ATTR(ad_user_port_key, 0644,
		   bonding_show_ad_user_port_key, bonding_sysfs_store_option);
		   bonding_show_ad_user_port_key, bonding_sysfs_store_option);


static struct attribute *per_bond_attrs[] = {
static struct attribute *per_bond_attrs[] = {
+2 −2
Original line number Original line Diff line number Diff line
@@ -26,7 +26,7 @@ const struct slave_attribute slave_attr_##_name = { \
	.show	= _show,					\
	.show	= _show,					\
};
};
#define SLAVE_ATTR_RO(_name)					\
#define SLAVE_ATTR_RO(_name)					\
	SLAVE_ATTR(_name, S_IRUGO, _name##_show)
	SLAVE_ATTR(_name, 0444, _name##_show)


static ssize_t state_show(struct slave *slave, char *buf)
static ssize_t state_show(struct slave *slave, char *buf)
{
{
+16 −16
Original line number Original line Diff line number Diff line
@@ -40,20 +40,20 @@ static LIST_HEAD(ser_list);
static LIST_HEAD(ser_release_list);
static LIST_HEAD(ser_release_list);


static bool ser_loop;
static bool ser_loop;
module_param(ser_loop, bool, S_IRUGO);
module_param(ser_loop, bool, 0444);
MODULE_PARM_DESC(ser_loop, "Run in simulated loopback mode.");
MODULE_PARM_DESC(ser_loop, "Run in simulated loopback mode.");


static bool ser_use_stx = true;
static bool ser_use_stx = true;
module_param(ser_use_stx, bool, S_IRUGO);
module_param(ser_use_stx, bool, 0444);
MODULE_PARM_DESC(ser_use_stx, "STX enabled or not.");
MODULE_PARM_DESC(ser_use_stx, "STX enabled or not.");


static bool ser_use_fcs = true;
static bool ser_use_fcs = true;


module_param(ser_use_fcs, bool, S_IRUGO);
module_param(ser_use_fcs, bool, 0444);
MODULE_PARM_DESC(ser_use_fcs, "FCS enabled or not.");
MODULE_PARM_DESC(ser_use_fcs, "FCS enabled or not.");


static int ser_write_chunk = MAX_WRITE_CHUNK;
static int ser_write_chunk = MAX_WRITE_CHUNK;
module_param(ser_write_chunk, int, S_IRUGO);
module_param(ser_write_chunk, int, 0444);


MODULE_PARM_DESC(ser_write_chunk, "Maximum size of data written to UART.");
MODULE_PARM_DESC(ser_write_chunk, "Maximum size of data written to UART.");


@@ -97,19 +97,19 @@ static inline void debugfs_init(struct ser_device *ser, struct tty_struct *tty)
	ser->debugfs_tty_dir =
	ser->debugfs_tty_dir =
			debugfs_create_dir(tty->name, debugfsdir);
			debugfs_create_dir(tty->name, debugfsdir);
	if (!IS_ERR(ser->debugfs_tty_dir)) {
	if (!IS_ERR(ser->debugfs_tty_dir)) {
		debugfs_create_blob("last_tx_msg", S_IRUSR,
		debugfs_create_blob("last_tx_msg", 0400,
				    ser->debugfs_tty_dir,
				    ser->debugfs_tty_dir,
				    &ser->tx_blob);
				    &ser->tx_blob);


		debugfs_create_blob("last_rx_msg", S_IRUSR,
		debugfs_create_blob("last_rx_msg", 0400,
				    ser->debugfs_tty_dir,
				    ser->debugfs_tty_dir,
				    &ser->rx_blob);
				    &ser->rx_blob);


		debugfs_create_x32("ser_state", S_IRUSR,
		debugfs_create_x32("ser_state", 0400,
				   ser->debugfs_tty_dir,
				   ser->debugfs_tty_dir,
				   (u32 *)&ser->state);
				   (u32 *)&ser->state);


		debugfs_create_x8("tty_status", S_IRUSR,
		debugfs_create_x8("tty_status", 0400,
				  ser->debugfs_tty_dir,
				  ser->debugfs_tty_dir,
				  &ser->tty_status);
				  &ser->tty_status);


+8 −8
Original line number Original line Diff line number Diff line
@@ -35,27 +35,27 @@ MODULE_DESCRIPTION("CAIF SPI driver");
#define PAD_POW2(x, pow) ((((x)&((pow)-1))==0) ? 0 : (((pow)-((x)&((pow)-1)))))
#define PAD_POW2(x, pow) ((((x)&((pow)-1))==0) ? 0 : (((pow)-((x)&((pow)-1)))))


static bool spi_loop;
static bool spi_loop;
module_param(spi_loop, bool, S_IRUGO);
module_param(spi_loop, bool, 0444);
MODULE_PARM_DESC(spi_loop, "SPI running in loopback mode.");
MODULE_PARM_DESC(spi_loop, "SPI running in loopback mode.");


/* SPI frame alignment. */
/* SPI frame alignment. */
module_param(spi_frm_align, int, S_IRUGO);
module_param(spi_frm_align, int, 0444);
MODULE_PARM_DESC(spi_frm_align, "SPI frame alignment.");
MODULE_PARM_DESC(spi_frm_align, "SPI frame alignment.");


/*
/*
 * SPI padding options.
 * SPI padding options.
 * Warning: must be a base of 2 (& operation used) and can not be zero !
 * Warning: must be a base of 2 (& operation used) and can not be zero !
 */
 */
module_param(spi_up_head_align, int, S_IRUGO);
module_param(spi_up_head_align, int, 0444);
MODULE_PARM_DESC(spi_up_head_align, "SPI uplink head alignment.");
MODULE_PARM_DESC(spi_up_head_align, "SPI uplink head alignment.");


module_param(spi_up_tail_align, int, S_IRUGO);
module_param(spi_up_tail_align, int, 0444);
MODULE_PARM_DESC(spi_up_tail_align, "SPI uplink tail alignment.");
MODULE_PARM_DESC(spi_up_tail_align, "SPI uplink tail alignment.");


module_param(spi_down_head_align, int, S_IRUGO);
module_param(spi_down_head_align, int, 0444);
MODULE_PARM_DESC(spi_down_head_align, "SPI downlink head alignment.");
MODULE_PARM_DESC(spi_down_head_align, "SPI downlink head alignment.");


module_param(spi_down_tail_align, int, S_IRUGO);
module_param(spi_down_tail_align, int, 0444);
MODULE_PARM_DESC(spi_down_tail_align, "SPI downlink tail alignment.");
MODULE_PARM_DESC(spi_down_tail_align, "SPI downlink tail alignment.");


#ifdef CONFIG_ARM
#ifdef CONFIG_ARM
@@ -250,10 +250,10 @@ static const struct file_operations dbgfs_frame_fops = {
static inline void dev_debugfs_add(struct cfspi *cfspi)
static inline void dev_debugfs_add(struct cfspi *cfspi)
{
{
	cfspi->dbgfs_dir = debugfs_create_dir(cfspi->pdev->name, dbgfs_root);
	cfspi->dbgfs_dir = debugfs_create_dir(cfspi->pdev->name, dbgfs_root);
	cfspi->dbgfs_state = debugfs_create_file("state", S_IRUGO,
	cfspi->dbgfs_state = debugfs_create_file("state", 0444,
						 cfspi->dbgfs_dir, cfspi,
						 cfspi->dbgfs_dir, cfspi,
						 &dbgfs_state_fops);
						 &dbgfs_state_fops);
	cfspi->dbgfs_frame = debugfs_create_file("frame", S_IRUGO,
	cfspi->dbgfs_frame = debugfs_create_file("frame", 0444,
						 cfspi->dbgfs_dir, cfspi,
						 cfspi->dbgfs_dir, cfspi,
						 &dbgfs_frame_fops);
						 &dbgfs_frame_fops);
}
}
Loading