Commit d60ba8de authored Jul 07, 2020 by Tom Rix Committed by David Sterba Jul 27, 2020

btrfs: ref-verify: fix memory leak in add_block_entry



clang static analysis flags this error

fs/btrfs/ref-verify.c:290:3: warning: Potential leak of memory pointed to by 're' [unix.Malloc]
                kfree(be);
                ^~~~~

The problem is in this block of code:

	if (root_objectid) {
		struct root_entry *exist_re;

		exist_re = insert_root_entry(&exist->roots, re);
		if (exist_re)
			kfree(re);
	}

There is no 'else' block freeing when root_objectid is 0. Add the
missing kfree to the else branch.

Fixes: fd708b81 ("Btrfs: add a extent ref verify tool")
CC: stable@vger.kernel.org # 4.19+
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent d85327b1

fs/btrfs/ref-verify.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -286,6 +286,8 @@ static struct block_entry add_block_entry(struct btrfs_fs_info fs_info,
		exist_re = insert_root_entry(&exist->roots, re);
		if (exist_re)
		kfree(re);
		} else {
		kfree(re);
		}
		kfree(be);
		return exist;

Admin message