Commit d5dea7d9 authored Oct 17, 2011 by Eric W. Biederman Committed by Jesse Barnes Jan 06, 2012

PCI: msi: Disable msi interrupts when we initialize a pci device



I traced a nasty kexec on panic boot failure to the fact that we had
screaming msi interrupts and we were not disabling the msi messages at
kernel startup.  The booting kernel had not enabled those interupts so
was not prepared to handle them.

I can see no reason why we would ever want to leave the msi interrupts
enabled at boot if something else has enabled those interrupts.  The pci
spec specifies that msi interrupts should be off by default.  Drivers
are expected to enable the msi interrupts if they want to use them.  Our
interrupt handling code reprograms the interrupt handlers at boot and
will not be be able to do anything useful with an unexpected interrupt.

This patch applies cleanly all of the way back to 2.6.32 where I noticed
the problem.

Cc: stable@kernel.org
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

parent 4716a450

drivers/pci/msi.c

+10 −0

Original line number	Original line	Diff line number	Diff line
	@@ -981,5 +981,15 @@ EXPORT_SYMBOL(pci_msi_enabled);

	void pci_msi_init_pci_dev(struct pci_dev *dev)		void pci_msi_init_pci_dev(struct pci_dev *dev)
	{		{
			int pos;
	INIT_LIST_HEAD(&dev->msi_list);		INIT_LIST_HEAD(&dev->msi_list);

			/* Disable the msi hardware to avoid screaming interrupts
			* during boot. This is the power on reset default so
			* usually this should be a noop.
			*/
			pos = pci_find_capability(dev, PCI_CAP_ID_MSI);
			if (pos)
			msi_set_enable(dev, pos, 0);
			msix_set_enable(dev, 0);
	}		}

Admin message