Commit d599af65 authored Nov 20, 2015 by Mika Westerberg Committed by Mark Brown Nov 20, 2015

spi: pxa2xx: Remove redundant call to lpss_ssp_setup() in probe



Commit 8b136baa ("spi: pxa2xx: Detect number of enabled Intel LPSS SPI
chip select signals") added a block where lpss_ssp_setup() gets called
again for Intel LPSS SPI host controllers before checking number of chip
selects from the capabilities register.

There is no point in calling the function twice in probe so remove the
first call.

Reported-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 8005c49d

drivers/spi/spi-pxa2xx.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1567,9 +1567,6 @@ static int pxa2xx_spi_probe(struct platform_device *pdev)
		if (!is_quark_x1000_ssp(drv_data))
		pxa2xx_spi_write(drv_data, SSPSP, 0);

		if (is_lpss_ssp(drv_data))
		lpss_ssp_setup(drv_data);

		if (is_lpss_ssp(drv_data)) {
		lpss_ssp_setup(drv_data);
		config = lpss_get_config(drv_data);

Admin message