Commit d5823511 authored Mar 13, 2017 by Johan Hovold Committed by Mauro Carvalho Chehab Apr 10, 2017

[media] dib0700: fix NULL-deref at probe



Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Fixes: c4018fa2 ("[media] dib0700: fix RC support on Hauppauge
Nova-TD")

Cc: stable <stable@vger.kernel.org>     # 3.16
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent bff8ff65

drivers/media/usb/dvb-usb/dib0700_core.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -809,6 +809,9 @@ int dib0700_rc_setup(struct dvb_usb_device d, struct usb_interface intf)

		/* Starting in firmware 1.20, the RC info is provided on a bulk pipe */

		if (intf->altsetting[0].desc.bNumEndpoints < rc_ep + 1)
		return -ENODEV;

		purb = usb_alloc_urb(0, GFP_KERNEL);
		if (purb == NULL)
		return -ENOMEM;

Admin message