Commit d5654efd authored Dec 03, 2008 by Wei Yongjun Committed by David S. Miller Dec 03, 2008

xfrm: Fix kernel panic when flush and dump SPD entries



After flush the SPD entries, dump the SPD entries will cause kernel painc.

Used the following commands to reproduct:

- echo 'spdflush;' | setkey -c
- echo 'spdadd 3ffe:501:ffff:ff01::/64 3ffe:501:ffff:ff04::/64  any -P out ipsec \
  ah/tunnel/3ffe:501:ffff:ff00:200:ff:fe00:b0b0-3ffe:501:ffff:ff02:200:ff:fe00:a1a1/require;\
  spddump;' | setkey -c
- echo 'spdflush; spddump;' | setkey -c
- echo 'spdadd 3ffe:501:ffff:ff01::/64 3ffe:501:ffff:ff04::/64  any -P out ipsec \
  ah/tunnel/3ffe:501:ffff:ff00:200:ff:fe00:b0b0-3ffe:501:ffff:ff02:200:ff:fe00:a1a1/require;\
  spddump;' | setkey -c

This is because when flush the SPD entries, the SPD entry is not remove
from the list.

This patch fix the problem by remove the SPD entry from the list.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f6f7b52e

net/xfrm/xfrm_policy.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -817,6 +817,7 @@ int xfrm_policy_flush(u8 type, struct xfrm_audit *audit_info)
		continue;
		hlist_del(&pol->bydst);
		hlist_del(&pol->byidx);
		list_del(&pol->walk.all);
		write_unlock_bh(&xfrm_policy_lock);

		xfrm_audit_policy_delete(pol, 1, audit_info->loginuid,

Admin message