Commit d55438be authored Sep 14, 2012 by Timur Tabi Committed by Mark Brown Sep 18, 2012

ASoC: fsl: remove unnecessary call to dma_unmap_single

Remove a call to dma_unmap_single() from the PowerPC ASoC DMA driver. The
buffer is allocated and not actually mapped, so the unmap call doesn't
make sense. It was probably left over from some early version of the driver.

This bug was unnoticed for so long because the DMA mapping functions normally
don't do anything on PowerPC.

Signed-off-by: Timur Tabi <timur@freescale.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 13c57e5b

sound/soc/fsl/fsl_dma.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -823,12 +823,6 @@ static int fsl_dma_close(struct snd_pcm_substream *substream)
		if (dma_private->irq)
		free_irq(dma_private->irq, dma_private);

		if (dma_private->ld_buf_phys) {
		dma_unmap_single(dev, dma_private->ld_buf_phys,
		sizeof(dma_private->link),
		DMA_TO_DEVICE);
		}

		/* Deallocate the fsl_dma_private structure */
		dma_free_coherent(dev, sizeof(struct fsl_dma_private),
		dma_private, dma_private->ld_buf_phys);

Admin message