Commit d544d273 authored Apr 30, 2015 by Greg Kroah-Hartman

USB: hub.c: move assignment out of if () block



We should not be doing assignments within an if () block
so fix up the code to not do this.

change was created using Coccinelle.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Petr Mladek <pmladek@suse.cz>
CC: Peter Chen <peter.chen@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Felipe Balbi <balbi@ti.com>

parent c688d621

drivers/usb/core/hub.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -795,7 +795,8 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
		* since each TT has "at least two" buffers that can need it (and
		* there can be many TTs per hub). even if they're uncommon.
		*/
		if ((clear = kmalloc (sizeof *clear, GFP_ATOMIC)) == NULL) {
		clear = kmalloc(sizeof *clear, GFP_ATOMIC);
		if (clear == NULL) {
		dev_err (&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
		/* FIXME recover somehow ... RESET_TT? */
		return -ENOMEM;

Admin message