Commit d51ea5dd authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: qgroup: Re-arrange tracepoint timing to co-operate with reserved space tracepoint 



Newly introduced qgroup reserved space trace points are normally nested
into several common qgroup operations.

While some other trace points are not well placed to co-operate with
them, causing confusing output.

This patch re-arrange trace_btrfs_qgroup_release_data() and
trace_btrfs_qgroup_free_delayed_ref() trace points so they are triggered
before reserved space ones.

Signed-off-by: default avatarQu Wenruo <quwenruo@cn.fujitsu.com>
Reviewed-by: default avatarJeff Mahoney <jeffm@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 3159fe7b

fs/btrfs/qgroup.c

+5 −5
Original line number Diff line number Diff line
@@ -2857,14 +2857,14 @@ static int __btrfs_qgroup_release_data(struct inode *inode, u64 start, u64 len, 
	if (ret < 0)

		goto out;



	if (free) {

		btrfs_qgroup_free_refroot(BTRFS_I(inode)->root->fs_info,

				BTRFS_I(inode)->root->objectid,

				changeset.bytes_changed);

	if (free)

		trace_op = QGROUP_FREE;

	}

	trace_btrfs_qgroup_release_data(inode, start, len,

					changeset.bytes_changed, trace_op);

	if (free)

		btrfs_qgroup_free_refroot(BTRFS_I(inode)->root->fs_info,

				BTRFS_I(inode)->root->objectid,

				changeset.bytes_changed);

out:

	ulist_release(&changeset.range_changed);

	return ret;

fs/btrfs/qgroup.h

+1 −5
Original line number Diff line number Diff line
@@ -230,15 +230,11 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, 
			 struct btrfs_qgroup_inherit *inherit);

void btrfs_qgroup_free_refroot(struct btrfs_fs_info *fs_info,

			       u64 ref_root, u64 num_bytes);

/*

 * TODO: Add proper trace point for it, as btrfs_qgroup_free() is

 * called by everywhere, can't provide good trace for delayed ref case.

 */

static inline void btrfs_qgroup_free_delayed_ref(struct btrfs_fs_info *fs_info,

						 u64 ref_root, u64 num_bytes)

{

	btrfs_qgroup_free_refroot(fs_info, ref_root, num_bytes);

	trace_btrfs_qgroup_free_delayed_ref(fs_info, ref_root, num_bytes);

	btrfs_qgroup_free_refroot(fs_info, ref_root, num_bytes);

}



#ifdef CONFIG_BTRFS_FS_RUN_SANITY_TESTS

CRA Git | Maintained and supported by SUSTech CRA and CCSE