Commit d518691c authored Apr 16, 2020 by Sebastian Andrzej Siewior Committed by David S. Miller Apr 16, 2020

amd-xgbe: Use __napi_schedule() in BH context



The driver uses __napi_schedule_irqoff() which is fine as long as it is
invoked with disabled interrupts by everybody. Since the commit
mentioned below the driver may invoke xgbe_isr_task() in tasklet/softirq
context. This may lead to list corruption if another driver uses
__napi_schedule_irqoff() in IRQ context.

Use __napi_schedule() which safe to use from IRQ and softirq context.

Fixes: 85b85c85 ("amd-xgbe: Re-issue interrupt if interrupt status not cleared")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 05eab4f3

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -514,7 +514,7 @@ static void xgbe_isr_task(unsigned long data)
		xgbe_disable_rx_tx_ints(pdata);

		/* Turn on polling */
		__napi_schedule_irqoff(&pdata->napi);
		__napi_schedule(&pdata->napi);
		}
		} else {
		/* Don't clear Rx/Tx status if doing per channel DMA

Admin message