Commit d5071f08 authored Sep 04, 2020 by Lorenzo Pieralisi

PCI: mvebu: Remove useless msi_controller pointer allocation

The mvebu host controller driver allocates an msi_controller structure
pointer without allocating the structure and initializing its methods,
which makes the pointer useless.

This means that the PCI IRQ MSI layer ignores it and that after all it
should not really be needed.

Remove it.

Link: https://lore.kernel.org/r/20200904142132.6054-1-lorenzo.pieralisi@arm.com


Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

parent 9123e3a7

drivers/pci/controller/pci-mvebu.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -12,7 +12,6 @@
		#include <linux/gpio.h>
		#include <linux/init.h>
		#include <linux/mbus.h>
		#include <linux/msi.h>
		#include <linux/slab.h>
		#include <linux/platform_device.h>
		#include <linux/of_address.h>
		@@ -70,7 +69,6 @@ struct mvebu_pcie_port;
		struct mvebu_pcie {
		struct platform_device *pdev;
		struct mvebu_pcie_port *ports;
		struct msi_controller *msi;
		struct resource io;
		struct resource realio;
		struct resource mem;
		@@ -1127,7 +1125,6 @@ static int mvebu_pcie_probe(struct platform_device *pdev)
		bridge->sysdata = pcie;
		bridge->ops = &mvebu_pcie_ops;
		bridge->align_resource = mvebu_pcie_align_resource;
		bridge->msi = pcie->msi;

		return mvebu_pci_host_probe(bridge);
		}

Admin message