staging: android: Clean up else statement from binder_send_failed_reply (d4ec15e1) · Commits · 戴 / test

Kernel coding style. Remove useless else statement after return. Changes from v1 and v2: Fix warning for mixed declarations and code. Declaration of "struct binder_transaction *next" made outside of while. Changes from v3: Removed initialization to NULL for next variable. Signed-off-by:

Lucas Tanure <tanure@linux.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/android/binder.c

+14 −14

Original line number	Diff line number	Diff line
		@@ -1185,6 +1185,7 @@ static void binder_send_failed_reply(struct binder_transaction *t,
		uint32_t error_code)
		{
		struct binder_thread *target_thread;
		struct binder_transaction *next;

		BUG_ON(t->flags & TF_ONE_WAY);
		while (1) {
		@@ -1212,8 +1213,8 @@ static void binder_send_failed_reply(struct binder_transaction *t,
		target_thread->return_error);
		}
		return;
		} else {
		struct binder_transaction *next = t->from_parent;
		}
		next = t->from_parent;

		binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
		"send failed reply for transaction %d, target dead\n",
		@@ -1231,7 +1232,6 @@ static void binder_send_failed_reply(struct binder_transaction *t,
		t->debug_id);
		}
		}
		}

		static void binder_transaction_buffer_release(struct binder_proc *proc,
		struct binder_buffer *buffer,

Admin message