UBIFS: replace seq_printf by seq_puts (d4eb08ff) · Commits · 戴 / test

Fix checkpatch warnings: "WARNING: Prefer seq_puts to seq_printf" Andrew Morton wrote: " - puts is presumably faster - puts doesn't go rogue if you accidentally pass it a "%". - this patch actually made fs/ubifs/super.o 12 bytes smaller. Perhaps because seq_printf() is a varargs function, forcing the caller to pass args on the stack instead of in registers. " Signed-off-by:

Fabian Frederick <fabf@skynet.be> Signed-off-by:

Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

fs/ubifs/super.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -424,19 +424,19 @@ static int ubifs_show_options(struct seq_file s, struct dentry root)
		struct ubifs_info *c = root->d_sb->s_fs_info;

		if (c->mount_opts.unmount_mode == 2)
		seq_printf(s, ",fast_unmount");
		seq_puts(s, ",fast_unmount");
		else if (c->mount_opts.unmount_mode == 1)
		seq_printf(s, ",norm_unmount");
		seq_puts(s, ",norm_unmount");

		if (c->mount_opts.bulk_read == 2)
		seq_printf(s, ",bulk_read");
		seq_puts(s, ",bulk_read");
		else if (c->mount_opts.bulk_read == 1)
		seq_printf(s, ",no_bulk_read");
		seq_puts(s, ",no_bulk_read");

		if (c->mount_opts.chk_data_crc == 2)
		seq_printf(s, ",chk_data_crc");
		seq_puts(s, ",chk_data_crc");
		else if (c->mount_opts.chk_data_crc == 1)
		seq_printf(s, ",no_chk_data_crc");
		seq_puts(s, ",no_chk_data_crc");

		if (c->mount_opts.override_compr) {
		seq_printf(s, ",compr=%s",

Admin message