ASoC: omap-mcbsp: Enable/disable sidetone block auto clock gating for omap3 (d4e44f14) · Commits · 戴 / test

OMAP3's McBSP2 and McBSP3 module have integrated sidetone block with dedicated SYSCONFIG register. The sidetone is operating from the maain McBSP module's ICLK. For normal operation the sidetone clock auto idle support needs to be disabled when it is activated. Note: This is not enough to avoid choppy sidetone because this AUTOIDLE bit is controlling only the clock auto idle from the McBSP to the sidetone block. If the McBSP_ICLK is idling, the sidetone clock is going to do the same. Signed-off-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/omap/mcbsp.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -260,6 +260,10 @@ static void omap_st_on(struct omap_mcbsp *mcbsp)
		if (mcbsp->pdata->enable_st_clock)
		mcbsp->pdata->enable_st_clock(mcbsp->id, 1);

		/* Disable Sidetone clock auto-gating for normal operation */
		w = MCBSP_ST_READ(mcbsp, SYSCONFIG);
		MCBSP_ST_WRITE(mcbsp, SYSCONFIG, w & ~(ST_AUTOIDLE));

		/* Enable McBSP Sidetone */
		w = MCBSP_READ(mcbsp, SSELCR);
		MCBSP_WRITE(mcbsp, SSELCR, w \| SIDETONEEN);
		@@ -279,6 +283,10 @@ static void omap_st_off(struct omap_mcbsp *mcbsp)
		w = MCBSP_READ(mcbsp, SSELCR);
		MCBSP_WRITE(mcbsp, SSELCR, w & ~(SIDETONEEN));

		/* Enable Sidetone clock auto-gating to reduce power consumption */
		w = MCBSP_ST_READ(mcbsp, SYSCONFIG);
		MCBSP_ST_WRITE(mcbsp, SYSCONFIG, w \| ST_AUTOIDLE);

		if (mcbsp->pdata->enable_st_clock)
		mcbsp->pdata->enable_st_clock(mcbsp->id, 0);
		}

Admin message