Commit d4d81387 authored May 08, 2020 by Weihang Li Committed by Jason Gunthorpe May 19, 2020

RDMA/hns: Fix error with to_hr_hem_entries_count()

For ilog2(x), if x is 0 and not a constant variable, it will return
-1. And there will be an error as below:

 hns3 0000:7d:00.0 hns_0: Local work queue 0x8 catast error, sub_event type is: 2

So modify to_hr_hem_entries_shift() to return 0 if conut is 0.

Fixes: 54d66387 ("RDMA/hns: Optimize WQE buffer size calculating process")
Link: https://lore.kernel.org/r/1588931159-56875-6-git-send-email-liweihang@huawei.com


Signed-off-by: Weihang Li <liweihang@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 6968aeb5

drivers/infiniband/hw/hns/hns_roce_device.h

+3 −0

Original line number	Diff line number	Diff line
		@@ -1112,6 +1112,9 @@ static inline u32 to_hr_hem_entries_count(u32 count, u32 buf_shift)

		static inline u32 to_hr_hem_entries_shift(u32 count, u32 buf_shift)
		{
		if (!count)
		return 0;

		return ilog2(to_hr_hem_entries_count(count, buf_shift));
		}

Admin message