Commit d4bc4c5f authored Mar 27, 2020 by Brian Foster Committed by Darrick J. Wong Mar 28, 2020

xfs: return locked status of inode buffer on xfsaild push



If the inode buffer backing a particular inode is locked,
xfs_iflush() returns -EAGAIN and xfs_inode_item_push() skips the
inode. It still returns success to xfsaild, however, which bypasses
the xfsaild backoff heuristic. Update xfs_inode_item_push() to
return locked status if the inode buffer couldn't be locked.

Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 8d3d7e2b

fs/xfs/xfs_inode_item.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -552,7 +552,8 @@ xfs_inode_item_push(
		if (!xfs_buf_delwri_queue(bp, buffer_list))
		rval = XFS_ITEM_FLUSHING;
		xfs_buf_relse(bp);
		}
		} else if (error == -EAGAIN)
		rval = XFS_ITEM_LOCKED;

		spin_lock(&lip->li_ailp->ail_lock);
		out_unlock:

Admin message