Commit d4a36e82 authored May 28, 2019 by Yoshihiro Shimoda Committed by Kishon Vijay Abraham I Jun 12, 2019

phy: renesas: rcar-gen2: Fix memory leak at error paths



This patch fixes memory leak at error paths of the probe function.
In for_each_child_of_node, if the loop returns, the driver should
call of_put_node() before returns.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Fixes: 1233f59f ("phy: Renesas R-Car Gen2 PHY driver")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

parent d9801081

drivers/phy/renesas/phy-rcar-gen2.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -391,6 +391,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
		error = of_property_read_u32(np, "reg", &channel_num);
		if (error \|\| channel_num > 2) {
		dev_err(dev, "Invalid \"reg\" property\n");
		of_node_put(np);
		return error;
		}
		channel->select_mask = select_mask[channel_num];
		@@ -406,6 +407,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
		data->gen2_phy_ops);
		if (IS_ERR(phy->phy)) {
		dev_err(dev, "Failed to create PHY\n");
		of_node_put(np);
		return PTR_ERR(phy->phy);
		}
		phy_set_drvdata(phy->phy, phy);

Admin message