Commit d47d1d27 authored Jan 05, 2017 by Stefan Hajnoczi Committed by Dan Williams Jan 12, 2017

pmem: return EIO on read_pmem() failure



The read_pmem() function uses memcpy_mcsafe() on x86 where an EFAULT
error code indicates a failed read.  Block I/O should use EIO to
indicate failure.  Other pmem code paths (like bad blocks) already use
EIO so let's be consistent.

This fixes compatibility with consumers like btrfs that try to parse the
specific error code rather than treat all errors the same.

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent a121103c

drivers/nvdimm/pmem.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -90,7 +90,9 @@ static int read_pmem(struct page *page, unsigned int off,

		rc = memcpy_from_pmem(mem + off, pmem_addr, len);
		kunmap_atomic(mem);
		return rc;
		if (rc)
		return -EIO;
		return 0;
		}

		static int pmem_do_bvec(struct pmem_device pmem, struct page page,

Admin message