Commit d47ce2ec authored Oct 19, 2011 by Allan Stephens Committed by Paul Gortmaker Dec 27, 2011

tipc: Eliminate useless memset operations in Ethernet media support

Gets rid of two pointless operations that zero out the array used to
record information about TIPC's Ethernet bearers. There is no need to
initialize the array on start up since it is a global variable that is
already zero'd out, and there is no need to zero it out on exit because
the array is never referenced again.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

parent 64b32f7e

net/tipc/eth_media.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -371,8 +371,6 @@ int tipc_eth_media_start(void)
		if (eth_started)
		return -EINVAL;

		memset(eth_bearers, 0, sizeof(eth_bearers));

		res = tipc_register_media(&eth_media_info);
		if (res)
		return res;
		@@ -396,6 +394,5 @@ void tipc_eth_media_stop(void)

		flush_scheduled_work();
		unregister_netdevice_notifier(&notifier);
		memset(&eth_bearers, 0, sizeof(eth_bearers));
		eth_started = 0;
		}

Admin message