Commit d46a7640 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Darren Hart
Browse files

intel-rst: Use ACPI_FAILURE() macro instead !ACPI_SUCCESS() for error checking 



ACPI_SUCCESS is defined as:
#define ACPI_SUCCESS(a)			(!(a))

There is no need for the the double ! since there is already a macro
defined for failures: ACPI_FAILURE()

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 72a979f0

drivers/platform/x86/intel-rst.c

+4 −4
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ static ssize_t irst_show_wakeup_events(struct device *dev, 
	acpi = to_acpi_device(dev);



	status = acpi_evaluate_integer(acpi->handle, "GFFS", NULL, &value);

	if (!ACPI_SUCCESS(status))

	if (ACPI_FAILURE(status))

		return -EINVAL;



	return sprintf(buf, "%lld\n", value);
@@ -59,7 +59,7 @@ static ssize_t irst_store_wakeup_events(struct device *dev, 


	status = acpi_execute_simple_method(acpi->handle, "SFFS", value);



	if (!ACPI_SUCCESS(status))

	if (ACPI_FAILURE(status))

		return -EINVAL;



	return count;
@@ -81,7 +81,7 @@ static ssize_t irst_show_wakeup_time(struct device *dev, 
	acpi = to_acpi_device(dev);



	status = acpi_evaluate_integer(acpi->handle, "GFTV", NULL, &value);

	if (!ACPI_SUCCESS(status))

	if (ACPI_FAILURE(status))

		return -EINVAL;



	return sprintf(buf, "%lld\n", value);
@@ -105,7 +105,7 @@ static ssize_t irst_store_wakeup_time(struct device *dev, 


	status = acpi_execute_simple_method(acpi->handle, "SFTV", value);



	if (!ACPI_SUCCESS(status))

	if (ACPI_FAILURE(status))

		return -EINVAL;



	return count;

CRA Git | Maintained and supported by SUSTech CRA and CCSE