Commit d445d46d authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'spi-v3.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi 

Pull spi fixes from Mark Brown:
 "A couple of driver specific fixes:

   - Disable DMA mode for i.MX6DL chips due to a hardware bug.

   - Don't use devm_kzalloc() outside of bind/unbind paths in the
     fsl-dspi driver, fixing memory leaks"

* tag 'spi-v3.19-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
  spi: imx: use pio mode for i.mx6dl
  spi: spi-fsl-dspi: Remove usage of devm_kzalloc
parents e7394c77 d426a842

drivers/spi/spi-fsl-dspi.c

+12 −2
Original line number Diff line number Diff line
@@ -342,8 +342,7 @@ static int dspi_setup_transfer(struct spi_device *spi, struct spi_transfer *t) 
	/* Only alloc on first setup */

	chip = spi_get_ctldata(spi);

	if (chip == NULL) {

		chip = devm_kzalloc(&spi->dev, sizeof(struct chip_data),

				    GFP_KERNEL);

		chip = kzalloc(sizeof(struct chip_data), GFP_KERNEL);

		if (!chip)

			return -ENOMEM;

	}
@@ -382,6 +381,16 @@ static int dspi_setup(struct spi_device *spi) 
	return dspi_setup_transfer(spi, NULL);

}



static void dspi_cleanup(struct spi_device *spi)

{

	struct chip_data *chip = spi_get_ctldata((struct spi_device *)spi);



	dev_dbg(&spi->dev, "spi_device %u.%u cleanup\n",

			spi->master->bus_num, spi->chip_select);



	kfree(chip);

}



static irqreturn_t dspi_interrupt(int irq, void *dev_id)

{

	struct fsl_dspi *dspi = (struct fsl_dspi *)dev_id;
@@ -467,6 +476,7 @@ static int dspi_probe(struct platform_device *pdev) 
	dspi->bitbang.master->setup = dspi_setup;

	dspi->bitbang.master->dev.of_node = pdev->dev.of_node;



	master->cleanup = dspi_cleanup;

	master->mode_bits = SPI_CPOL | SPI_CPHA;

	master->bits_per_word_mask = SPI_BPW_MASK(4) | SPI_BPW_MASK(8) |

					SPI_BPW_MASK(16);

drivers/spi/spi-imx.c

+4 −0
Original line number Diff line number Diff line
@@ -823,6 +823,10 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx, 
	struct dma_slave_config slave_config = {};

	int ret;



	/* use pio mode for i.mx6dl chip TKT238285 */

	if (of_machine_is_compatible("fsl,imx6dl"))

		return 0;



	/* Prepare for TX DMA: */

	master->dma_tx = dma_request_slave_channel(dev, "tx");

	if (!master->dma_tx) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE