Commit d43fdae7 authored Jul 25, 2018 by Mauricio Faria de Oliveira Committed by Jens Axboe Jul 27, 2018

partitions/aix: append null character to print data from disk



Even if properly initialized, the lvname array (i.e., strings)
is read from disk, and might contain corrupt data (e.g., lack
the null terminating character for strings).

So, make sure the partition name string used in pr_warn() has
the null terminating character.

Fixes: 6ceea22b ("partitions: add aix lvm partition support files")
Suggested-by: Daniel J. Axtens <daniel.axtens@canonical.com>
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 14cb2c8a

block/partitions/aix.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -283,10 +283,14 @@ int aix_partition(struct parsed_partitions *state)
		next_lp_ix += 1;
		}
		for (i = 0; i < state->limit; i += 1)
		if (lvip[i].pps_found && !lvip[i].lv_is_contiguous)
		if (lvip[i].pps_found && !lvip[i].lv_is_contiguous) {
		char tmp[sizeof(n[i].name) + 1]; // null char

		snprintf(tmp, sizeof(tmp), "%s", n[i].name);
		pr_warn("partition %s (%u pp's found) is "
		"not contiguous\n",
		n[i].name, lvip[i].pps_found);
		tmp, lvip[i].pps_found);
		}
		kfree(pvd);
		}
		kfree(n);

Admin message