Commit d43698e8 authored Apr 16, 2015 by Nicolas Iooss Committed by Linus Torvalds Apr 17, 2015

firmware/ihex2fw.c: restore missing default in switch statement



Commit 2473238e ("ihex: add support for CS:IP/EIP records") removes
the "default:" statement in the switch block, making the "return
usage();" line dead code and ihex2fw silently ignoring unknown options.
Restore this statement.

This bug was found by building with HOSTCC=clang and adding
-Wunreachable-code-return to HOSTCFLAGS.

Fixes: 2473238e ("ihex: add support for CS:IP/EIP records")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2afe27c7

firmware/ihex2fw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -86,6 +86,7 @@ int main(int argc, char **argv)
		case 'j':
		include_jump = 1;
		break;
		default:
		return usage();
		}
		}

Admin message