Commit d431b2e3 authored Apr 21, 2011 by Randy Dunlap Committed by Jiri Kosina Apr 21, 2011

HID: hid-example: fix some build issues



samples/hid-example.o needs some Kconfig and Makefile additions in order
to build.  It should use <linux/*.h> headers from the build tree, so use
HEADERS_CHECK to require that those header files be present.

Change the kconfig symbol from tristate to bool since userspace cannot be
built as loadable modules.

However, I don't understand why the userspace header files are not present
as reported in Andrew's build log, since it builds OK on x86_64 without
any of these changes.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alan Ott <alan@signal11.us>
Cc: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent cb3e85fe

samples/Kconfig

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -62,8 +62,8 @@ config SAMPLE_KDB
	command to the kdb shell.		command to the kdb shell.

	config SAMPLE_HIDRAW		config SAMPLE_HIDRAW
	tristate "Build simple hidraw example"		bool "Build simple hidraw example"
	depends on HIDRAW		depends on HIDRAW && HEADERS_CHECK
	help		help
	Build an example of how to use hidraw from userspace.		Build an example of how to use hidraw from userspace.

samples/hidraw/Makefile

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -6,3 +6,5 @@ hostprogs-y := hid-example

	# Tell kbuild to always build the programs		# Tell kbuild to always build the programs
	always := $(hostprogs-y)		always := $(hostprogs-y)

			HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include

Admin message