fpga: Fix dead store in fpga-bridge.c (d3fbd739) · Commits · 戴 / test

Using clang's scan-build/view this issue was flagged a dead store issue in fpga-bridge.c warning: Value stored to 'ret' is never read [deadcode.DeadStores] ret = id; Signed-off-by:

Tom Rix <trix@redhat.com> Signed-off-by:

Moritz Fischer <mdf@kernel.org>

drivers/fpga/fpga-bridge.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -328,7 +328,7 @@ struct fpga_bridge fpga_bridge_create(struct device dev, const char *name,
		void *priv)
		{
		struct fpga_bridge *bridge;
		int id, ret = 0;
		int id, ret;

		if (!name \|\| !strlen(name)) {
		dev_err(dev, "Attempt to register with no name!\n");
		@@ -340,10 +340,8 @@ struct fpga_bridge fpga_bridge_create(struct device dev, const char *name,
		return NULL;

		id = ida_simple_get(&fpga_bridge_ida, 0, 0, GFP_KERNEL);
		if (id < 0) {
		ret = id;
		if (id < 0)
		goto error_kfree;
		}

		mutex_init(&bridge->mutex);
		INIT_LIST_HEAD(&bridge->node);

Admin message