Commit d3f4caa3 authored Aug 20, 2015 by Fabio Estevam Committed by Bjorn Helgaas Aug 20, 2015

PCI: dra7xx: Remove unneeded use of IS_ERR_VALUE()



There is no need to use the IS_ERR_VALUE() macro for checking the return
value from pm_runtime_* functions.

Test for a negative pm_runtime_get_sync() return value instead of using
IS_ERR_VALUE().

The semantic patch that makes this change is available in
scripts/coccinelle/api/pm_runtime.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Kishon Vijay Abraham I <kishon@ti.com>

parent 73c8f0cb

drivers/pci/host/pci-dra7xx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -397,7 +397,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)

		pm_runtime_enable(dev);
		ret = pm_runtime_get_sync(dev);
		if (IS_ERR_VALUE(ret)) {
		if (ret < 0) {
		dev_err(dev, "pm_runtime_get_sync failed\n");
		goto err_get_sync;
		}

Admin message