Commit d3db90e2 authored Aug 22, 2006 by Chuck Lever Committed by Trond Myklebust Sep 22, 2006

NFS: remove a no-longer-needed error check in nfs_symlink()



In the early days of NFS, there was no duplicate reply cache on the server.
Thus retransmitted non-idempotent requests often found that the request had
already completed on the server.  To avoid passing an unanticipated return
code to unsuspecting applications, NFS clients would often shunt error
codes that implied the request had been retried but already completed.

Thanks to NFS over TCP, duplicate reply caches on the server, and network
performance and reliability improvements, it is safe to remove such checks.

Test plan:
None.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent b86acd50

fs/nfs/dir.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -1476,14 +1476,10 @@ dentry->d_parent->d_name.name, dentry->d_name.name);
		error = NFS_PROTO(dir)->symlink(dir, &dentry->d_name, &qsymname,
		&attr, &sym_fh, &sym_attr);
		nfs_end_data_update(dir);
		if (!error) {
		if (!error)
		error = nfs_instantiate(dentry, &sym_fh, &sym_attr);
		} else {
		if (error == -EEXIST)
		printk("nfs_proc_symlink: %s/%s already exists??\n",
		dentry->d_parent->d_name.name, dentry->d_name.name);
		else
		d_drop(dentry);
		}
		unlock_kernel();
		return error;
		}

Admin message