Commit d3d2948f authored Aug 29, 2017 by Roland Kammerer Committed by Jens Axboe Aug 29, 2017

drbd: abort drbd_start_resync if there is no connection



This was found by a static analysis tool. While highly unlikely, be sure
to return without dereferencing the NULL pointer.

Reported-by: Shaobo <shaobo@cs.utah.edu>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 183ece30

drivers/block/drbd/drbd_worker.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1756,6 +1756,11 @@ void drbd_start_resync(struct drbd_device *device, enum drbd_conns side)
		return;
		}

		if (!connection) {
		drbd_err(device, "No connection to peer, aborting!\n");
		return;
		}

		if (!test_bit(B_RS_H_DONE, &device->flags)) {
		if (side == C_SYNC_TARGET) {
		/* Since application IO was locked out during C_WF_BITMAP_T and

Admin message