Commit d3d239dc authored Jun 24, 2020 by Sascha Hauer Committed by David S. Miller Jun 24, 2020

net: ethernet: mvneta: Do not error out in non serdes modes



In mvneta_config_interface() the RGMII modes are catched by the default
case which is an error return. The RGMII modes are valid modes for the
driver, so instead of returning an error add a break statement to return
successfully.

This avoids this warning for non comphy SoCs which use RGMII, like
SolidRun Clearfog:

WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c

Fixes: b4748553 ("net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy")
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1ed9ec9b

drivers/net/ethernet/marvell/mvneta.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3571,7 +3571,7 @@ static int mvneta_config_interface(struct mvneta_port *pp,
		MVNETA_HSGMII_SERDES_PROTO);
		break;
		default:
		return -EINVAL;
		break;
		}
		}

Admin message