Commit d3cfe7dd authored May 01, 2019 by Sameeh Jubran Committed by David S. Miller May 04, 2019

net: ena: fix incorrect test of supported hash function



ena_com_set_hash_function() tests if a hash function is supported
by the device before setting it.
The test returns the opposite result than needed.
Reverse the condition to return the correct value.
Also use the BIT macro instead of inline shift.

Fixes: 1738cd3e ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b287cdbd

drivers/net/ethernet/amazon/ena/ena_com.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2195,7 +2195,7 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev)
		if (unlikely(ret))
		return ret;

		if (get_resp.u.flow_hash_func.supported_func & (1 << rss->hash_func)) {
		if (!(get_resp.u.flow_hash_func.supported_func & BIT(rss->hash_func))) {
		pr_err("Func hash %d isn't supported by device, abort\n",
		rss->hash_func);
		return -EOPNOTSUPP;

Admin message