Commit d3bb2686 authored Sep 06, 2019 by Colin Ian King Committed by Kalle Valo Sep 13, 2019

ssb: make array pwr_info_offset static const, makes object smaller



Don't populate the array pwr_info_offset on the stack but instead make it
static const. Makes the object code smaller by 207 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
  26066	   3000	     64	  29130	   71ca	drivers/ssb/pci.o

After:
   text	   data	    bss	    dec	    hex	filename
  25763	   3096	     64	  28923	   70fb	drivers/ssb/pci.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 527c5d37

drivers/ssb/pci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom out, const u16 in)
		{
		int i;
		u16 o;
		u16 pwr_info_offset[] = {
		static const u16 pwr_info_offset[] = {
		SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
		SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
		};

Admin message