Commit d3aea84a authored May 08, 2013 by Jeff Layton Committed by Eric Paris Nov 05, 2013

audit: log the audit_names record type



...to make it clear what the intent behind each record's operation was.

In many cases you can infer this, based on the context of the syscall
and the result. In other cases it's not so obvious. For instance, in
the case where you have a file being renamed over another, you'll have
two different records with the same filename but different inode info.
By logging this information we can clearly tell which one was created
and which was deleted.

This fixes what was broken in commit bfcec708.
Commit 79f6530c should also be backported to stable v3.7+.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>

parent 14e972b4

kernel/audit.c

+20 −0

Original line number	Diff line number	Diff line
		@@ -1640,6 +1640,26 @@ void audit_log_name(struct audit_context context, struct audit_names n,
		}
		}

		/* log the audit_names record type */
		audit_log_format(ab, " nametype=");
		switch(n->type) {
		case AUDIT_TYPE_NORMAL:
		audit_log_format(ab, "NORMAL");
		break;
		case AUDIT_TYPE_PARENT:
		audit_log_format(ab, "PARENT");
		break;
		case AUDIT_TYPE_CHILD_DELETE:
		audit_log_format(ab, "DELETE");
		break;
		case AUDIT_TYPE_CHILD_CREATE:
		audit_log_format(ab, "CREATE");
		break;
		default:
		audit_log_format(ab, "UNKNOWN");
		break;
		}

		audit_log_fcaps(ab, n);
		audit_log_end(ab);
		}

Admin message