Commit d3a85737 authored Oct 19, 2020 by Jérôme Pouiller Committed by Greg Kroah-Hartman Oct 27, 2020

staging: wfx: fix use of uninitialized pointer



With -Wuninitialized, the compiler complains:

drivers/staging/wfx/data_tx.c:34:19: warning: variable 'band' is uninitialized when used here [-Wuninitialized]
    if (rate->idx >= band->n_bitrates) {
                         ^~~~

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Fixes: 868fd970 ("staging: wfx: improve robustness of wfx_get_hw_rate()")
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Link: https://lore.kernel.org/r/20201019160604.1609180-1-Jerome.Pouiller@silabs.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b6ae84d6

drivers/staging/wfx/data_tx.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -31,13 +31,13 @@ static int wfx_get_hw_rate(struct wfx_dev *wdev,
		}
		return rate->idx + 14;
		}
		// WFx only support 2GHz, else band information should be retrieved
		// from ieee80211_tx_info
		band = wdev->hw->wiphy->bands[NL80211_BAND_2GHZ];
		if (rate->idx >= band->n_bitrates) {
		WARN(1, "wrong rate->idx value: %d", rate->idx);
		return -1;
		}
		// WFx only support 2GHz, else band information should be retrieved
		// from ieee80211_tx_info
		band = wdev->hw->wiphy->bands[NL80211_BAND_2GHZ];
		return band->bitrates[rate->idx].hw_value;
		}

Admin message