Commit d39da686 authored Dec 18, 2019 by Chris Wilson Committed by Jani Nikula Dec 23, 2019

drm/i915/gt: Ratelimit display power w/a

For very light workloads that frequently park, acquiring the display
power well (required to prevent the dmc from trashing the system) takes
longer than the execution. A good example is the igt_coherency selftest,
which is slowed down by an order of magnitude in the worst case with
powerwell cycling. To prevent frequent cycling, while keeping our fast
soft-rc6, use a timer to delay release of the display powerwell.

Fixes: 31177017 ("drm/i915/gt: Schedule request retirement when timeline idles")
References: https://gitlab.freedesktop.org/drm/intel/issues/848


Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191218093504.3477048-1-chris@chris-wilson.co.uk


(cherry picked from commit 81ff52b7)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

parent 74ac5780

drivers/gpu/drm/i915/gt/intel_gt_pm.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -94,8 +94,9 @@ static int __gt_park(struct intel_wakeref *wf)
		intel_uncore_forcewake_put(&i915->uncore, FORCEWAKE_ALL);
		}

		/* Defer dropping the display power well for 100ms, it's slow! */
		GEM_BUG_ON(!wakeref);
		intel_display_power_put(i915, POWER_DOMAIN_GT_IRQ, wakeref);
		intel_display_power_put_async(i915, POWER_DOMAIN_GT_IRQ, wakeref);

		i915_globals_park();

Admin message