Commit d396cb18 authored Jul 12, 2018 by Nicholas Mc Guire Committed by Wei Xu Jul 16, 2018

ARM: hisi: handle of_iomap and fix missing of_node_put



Relying on an unchecked of_iomap() which can return NULL is problematic
here, an explicit check seems mandatory. Also the call to
of_find_compatible_node() returns a device node with refcount incremented
therefor an explicit of_node_put() is needed here.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Fixes: commit 22bae429 ("ARM: hi3xxx: add hotplug support")
Signed-off-by: Wei Xu <xuwei5@hisilicon.com>

parent 81646a3d

arch/arm/mach-hisi/hotplug.c

+13 −6

Original line number	Diff line number	Diff line
		@@ -148,14 +148,21 @@ static int hi3xxx_hotplug_init(void)
		struct device_node *node;

		node = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
		if (node) {
		if (!node) {
		id = ERROR_CTRL;
		return -ENOENT;
		}

		ctrl_base = of_iomap(node, 0);
		of_node_put(node);
		if (!ctrl_base) {
		id = ERROR_CTRL;
		return -ENOMEM;
		}

		id = HI3620_CTRL;
		return 0;
		}
		id = ERROR_CTRL;
		return -ENOENT;
		}

		void hi3xxx_set_cpu(int cpu, bool enable)
		{

Admin message