Commit d378cdd0 authored by Gwendal Grignou's avatar Gwendal Grignou Committed by Enric Balletbo i Serra
Browse files

platform/chrome: cros_ec_debugfs: Control uptime information request 



When EC does not support uptime command (EC_CMD_GET_UPTIME_INFO),
do not create the uptime sysfs entry point.
User space application will not probe the file needlessly.

The EC console log will not contain EC_CMD_GET_UPTIME_INFO anymore.

Signed-off-by: default avatarGwendal Grignou <gwendal@chromium.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
parent b3a9e3b9

drivers/platform/chrome/cros_ec_debugfs.c

+22 −2
Original line number Diff line number Diff line
@@ -242,6 +242,25 @@ static ssize_t cros_ec_pdinfo_read(struct file *file, 
				       read_buf, p - read_buf);

}



static bool cros_ec_uptime_is_supported(struct cros_ec_device *ec_dev)

{

	struct {

		struct cros_ec_command cmd;

		struct ec_response_uptime_info resp;

	} __packed msg = {};

	int ret;



	msg.cmd.command = EC_CMD_GET_UPTIME_INFO;

	msg.cmd.insize = sizeof(msg.resp);



	ret = cros_ec_cmd_xfer_status(ec_dev, &msg.cmd);

	if (ret == -EPROTO && msg.cmd.result == EC_RES_INVALID_COMMAND)

		return false;



	/* Other errors maybe a transient error, do not rule about support. */

	return true;

}



static ssize_t cros_ec_uptime_read(struct file *file, char __user *user_buf,

				   size_t count, loff_t *ppos)

{
@@ -444,6 +463,7 @@ static int cros_ec_debugfs_probe(struct platform_device *pd) 
	debugfs_create_file("pdinfo", 0444, debug_info->dir, debug_info,

			    &cros_ec_pdinfo_fops);



	if (cros_ec_uptime_is_supported(ec->ec_dev))

		debugfs_create_file("uptime", 0444, debug_info->dir, debug_info,

				    &cros_ec_uptime_fops);

CRA Git | Maintained and supported by SUSTech CRA and CCSE