Unverified Commit d3645b05 authored Oct 21, 2019 by Xiaojun Sang Committed by Mark Brown Oct 21, 2019

ASoC: compress: fix unsigned integer overflow check



Parameter fragments and fragment_size are type of u32. U32_MAX is
the correct check.

Signed-off-by: Xiaojun Sang <xsang@codeaurora.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Vinod Koul <vkoul@kernel.org>
Link: https://lore.kernel.org/r/20191021095432.5639-1-srinivas.kandagatla@linaro.org


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 9110d1b0

sound/core/compress_offload.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -528,7 +528,7 @@ static int snd_compress_check_input(struct snd_compr_params *params)
		{
		/* first let's check the buffer parameter's */
		if (params->buffer.fragment_size == 0 \|\|
		params->buffer.fragments > INT_MAX / params->buffer.fragment_size \|\|
		params->buffer.fragments > U32_MAX / params->buffer.fragment_size \|\|
		params->buffer.fragments == 0)
		return -EINVAL;

Admin message