Commit d35bf9bc authored Feb 16, 2020 by Finn Thain Committed by David S. Miller Feb 16, 2020

net/sonic: Remove redundant netif_start_queue() call



The transmit queue must be running already otherwise sonic_send_packet()
would not have been called. If the queue was stopped by the interrupt
handler, the interrupt handler will restart it again.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 29660d50

drivers/net/ethernet/natsemi/sonic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -327,7 +327,7 @@ static int sonic_send_packet(struct sk_buff skb, struct net_device dev)
		netif_dbg(lp, tx_queued, dev, "%s: stopping queue\n", __func__);
		netif_stop_queue(dev);
		/* after this packet, wait for ISR to free up some TDAs */
		} else netif_start_queue(dev);
		}

		netif_dbg(lp, tx_queued, dev, "%s: issuing Tx command\n", __func__);

Admin message