Commit d34b0440 authored Aug 15, 2019 by Quentin Monnet Committed by Alexei Starovoitov Aug 15, 2019

tools: bpftool: close prog FD before exit on showing a single program



When showing metadata about a single program by invoking
"bpftool prog show PROG", the file descriptor referring to the program
is not closed before returning from the function. Let's close it.

Fixes: 71bb428f ("tools: bpf: add bpftool")
Signed-off-by: Quentin Monnet <quentin.monnet@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

parent 27df5c70

tools/bpf/bpftool/prog.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -363,7 +363,9 @@ static int do_show(int argc, char **argv)
		if (fd < 0)
		return -1;

		return show_prog(fd);
		err = show_prog(fd);
		close(fd);
		return err;
		}

		if (argc)

Admin message