Commit d34316a4 authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: fw-ohci: work around generation bug in TI controllers (fix AV/C and more) 

Unlike the ohci1394 driver, fw-ohci uses the selfIDGeneration field of
bus reset packets to determine the generation of incoming requests as
per OHCI 1.1 clause 8.4.2.3.  This is more precise --- provided that the
controller inserts the correct generation.  Texas Instruments chips
often don't.

This prevented the transmission of response packets, which for example
broke AV/C transactions as used when communicating with miniDV cameras
and any other AV/C devices.

There is apparently no way to detect and adjust incorrect generations.
Therefore we ignore the generation of bus reset packets from TI chips
and use the generation of the self ID buffer instead.  Alas this is
received at a slightly wrong time.  In rare cases, this could cause us
to not respond to legitimate requests or to respond to expired requests.
(The latter is less likely because the bus reset packet AR event is
typically handled before the self ID complete event.)

Bug reported by Mladen Kuntner, who was extraordinarily patient while
dealing with the driver maintainers.  Fix confirmed to be required and
effective for TSB82AA2 and a TSB43AB22 or TSB43AB22A.
https://bugzilla.redhat.com/show_bug.cgi?id=243081



Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: default avatarJarod Wilson <jwilson@redhat.com>
parent 08ddb2f4

drivers/firewire/fw-ohci.c

+16 −5
Original line number Original line Diff line number Diff line
@@ -181,6 +181,7 @@ struct fw_ohci { 
	int request_generation;

	int request_generation;

	u32 bus_seconds;

	u32 bus_seconds;

	bool old_uninorth;

	bool old_uninorth;

	bool bus_reset_packet_quirk;





	/*

	/*

	 * Spinlock for accessing fw_ohci data.  Never call out of

	 * Spinlock for accessing fw_ohci data.  Never call out of
@@ -571,14 +572,19 @@ static __le32 *handle_ar_packet(struct ar_context *ctx, __le32 *buffer) 
	 * generation.  We only need this for requests; for responses

	 * generation.  We only need this for requests; for responses

	 * we use the unique tlabel for finding the matching

	 * we use the unique tlabel for finding the matching

	 * request.

	 * request.

	 *

	 * Alas some chips sometimes emit bus reset packets with a

	 * wrong generation.  We set the correct generation for these

	 * at a slightly incorrect time (in bus_reset_tasklet).

	 */

	 */



	if (evt == OHCI1394_evt_bus_reset) {

	if (evt == OHCI1394_evt_bus_reset)

		if (!ohci->bus_reset_packet_quirk)

			ohci->request_generation = (p.header[2] >> 16) & 0xff;

			ohci->request_generation = (p.header[2] >> 16) & 0xff;

	else if (ctx == &ohci->ar_request_ctx)

	} else if (ctx == &ohci->ar_request_ctx) {

		fw_core_handle_request(&ohci->card, &p);

		fw_core_handle_request(&ohci->card, &p);

	else

	} else {

		fw_core_handle_response(&ohci->card, &p);

		fw_core_handle_response(&ohci->card, &p);

	}





	return buffer + length + 1;

	return buffer + length + 1;

}

}
@@ -1285,6 +1291,9 @@ static void bus_reset_tasklet(unsigned long data) 
	context_stop(&ohci->at_response_ctx);

	context_stop(&ohci->at_response_ctx);

	reg_write(ohci, OHCI1394_IntEventClear, OHCI1394_busReset);

	reg_write(ohci, OHCI1394_IntEventClear, OHCI1394_busReset);





	if (ohci->bus_reset_packet_quirk)

		ohci->request_generation = generation;



	/*

	/*

	 * This next bit is unrelated to the AT context stuff but we

	 * This next bit is unrelated to the AT context stuff but we

	 * have to do it under the spinlock also.  If a new config rom

	 * have to do it under the spinlock also.  If a new config rom
@@ -2360,6 +2369,8 @@ pci_probe(struct pci_dev *dev, const struct pci_device_id *ent) 
	ohci->old_uninorth = dev->vendor == PCI_VENDOR_ID_APPLE &&

	ohci->old_uninorth = dev->vendor == PCI_VENDOR_ID_APPLE &&

			     dev->device == PCI_DEVICE_ID_APPLE_UNI_N_FW;

			     dev->device == PCI_DEVICE_ID_APPLE_UNI_N_FW;

#endif

#endif

	ohci->bus_reset_packet_quirk = dev->vendor == PCI_VENDOR_ID_TI;



	spin_lock_init(&ohci->lock);

	spin_lock_init(&ohci->lock);





	tasklet_init(&ohci->bus_reset_tasklet,

	tasklet_init(&ohci->bus_reset_tasklet,

CRA Git | Maintained and supported by SUSTech CRA and CCSE