net: hns3: refactor the mailbox message between PF and VF (d3410018) · Commits · 戴 / test

drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h

+39 −7

Original line number	Diff line number	Diff line
		@@ -7,8 +7,6 @@
		#include <linux/mutex.h>
		#include <linux/types.h>

		#define HCLGE_MBX_VF_MSG_DATA_NUM 16

		enum HCLGE_MBX_OPCODE {
		HCLGE_MBX_RESET = 0x01, /* (VF -> PF) assert reset */
		HCLGE_MBX_ASSERTING_RESET, /* (PF -> VF) PF is asserting reset*/
		@@ -72,10 +70,15 @@ enum hclge_mbx_vlan_cfg_subcode {
		HCLGE_MBX_GET_PORT_BASE_VLAN_STATE, /* get port based vlan state */
		};

		#define HCLGE_MBX_MAX_MSG_SIZE 16
		#define HCLGE_MBX_MAX_MSG_SIZE 14
		#define HCLGE_MBX_MAX_RESP_DATA_SIZE 8U
		#define HCLGE_MBX_RING_MAP_BASIC_MSG_NUM 3
		#define HCLGE_MBX_RING_NODE_VARIABLE_NUM 3
		#define HCLGE_MBX_MAX_RING_CHAIN_PARAM_NUM 4

		struct hclge_ring_chain_param {
		u8 ring_type;
		u8 tqp_index;
		u8 int_gl_index;
		};

		struct hclgevf_mbx_resp_status {
		struct mutex mbx_mutex; /* protects against contending sync cmd resp */
		@@ -85,6 +88,35 @@ struct hclgevf_mbx_resp_status {
		u8 additional_info[HCLGE_MBX_MAX_RESP_DATA_SIZE];
		};

		struct hclge_vf_to_pf_msg {
		u8 code;
		union {
		struct {
		u8 subcode;
		u8 data[HCLGE_MBX_MAX_MSG_SIZE];
		};
		struct {
		u8 en_bc;
		u8 en_uc;
		u8 en_mc;
		};
		struct {
		u8 vector_id;
		u8 ring_num;
		struct hclge_ring_chain_param
		param[HCLGE_MBX_MAX_RING_CHAIN_PARAM_NUM];
		};
		};
		};

		struct hclge_pf_to_vf_msg {
		u16 code;
		u16 vf_mbx_msg_code;
		u16 vf_mbx_msg_subcode;
		u16 resp_status;
		u8 resp_data[HCLGE_MBX_MAX_RESP_DATA_SIZE];
		};

		struct hclge_mbx_vf_to_pf_cmd {
		u8 rsv;
		u8 mbx_src_vfid; /* Auto filled by IMP */
		@@ -92,7 +124,7 @@ struct hclge_mbx_vf_to_pf_cmd {
		u8 rsv1[1];
		u8 msg_len;
		u8 rsv2[3];
		u8 msg[HCLGE_MBX_MAX_MSG_SIZE];
		struct hclge_vf_to_pf_msg msg;
		};

		#define HCLGE_MBX_NEED_RESP_BIT BIT(0)
		@@ -102,7 +134,7 @@ struct hclge_mbx_pf_to_vf_cmd {
		u8 rsv[3];
		u8 msg_len;
		u8 rsv1[3];
		u16 msg[8];
		struct hclge_pf_to_vf_msg msg;
		};

		struct hclge_vf_rst_cmd {

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

+61 −63

Original line number	Diff line number	Diff line
		@@ -46,26 +46,28 @@ static int hclge_gen_resp_to_vf(struct hclge_vport *vport,
		resp_pf_to_vf->dest_vfid = vf_to_pf_req->mbx_src_vfid;
		resp_pf_to_vf->msg_len = vf_to_pf_req->msg_len;

		resp_pf_to_vf->msg[0] = HCLGE_MBX_PF_VF_RESP;
		resp_pf_to_vf->msg[1] = vf_to_pf_req->msg[0];
		resp_pf_to_vf->msg[2] = vf_to_pf_req->msg[1];
		resp_pf_to_vf->msg.code = HCLGE_MBX_PF_VF_RESP;
		resp_pf_to_vf->msg.vf_mbx_msg_code = vf_to_pf_req->msg.code;
		resp_pf_to_vf->msg.vf_mbx_msg_subcode = vf_to_pf_req->msg.subcode;
		resp = hclge_errno_to_resp(resp_status);
		if (resp < SHRT_MAX) {
		resp_pf_to_vf->msg[3] = resp;
		resp_pf_to_vf->msg.resp_status = resp;
		} else {
		dev_warn(&hdev->pdev->dev,
		"failed to send response to VF, response status %d is out-of-bound\n",
		resp);
		resp_pf_to_vf->msg[3] = EIO;
		resp_pf_to_vf->msg.resp_status = EIO;
		}

		if (resp_data && resp_data_len > 0)
		memcpy(&resp_pf_to_vf->msg[4], resp_data, resp_data_len);
		memcpy(resp_pf_to_vf->msg.resp_data, resp_data, resp_data_len);

		status = hclge_cmd_send(&hdev->hw, &desc, 1);
		if (status)
		dev_err(&hdev->pdev->dev,
		"PF failed(=%d) to send response to VF\n", status);
		"failed to send response to VF, status: %d, vfid: %u, code: %u, subcode: %u.\n",
		status, vf_to_pf_req->mbx_src_vfid,
		vf_to_pf_req->msg.code, vf_to_pf_req->msg.subcode);

		return status;
		}
		@@ -84,15 +86,15 @@ static int hclge_send_mbx_msg(struct hclge_vport vport, u8 msg, u16 msg_len,

		resp_pf_to_vf->dest_vfid = dest_vfid;
		resp_pf_to_vf->msg_len = msg_len;
		resp_pf_to_vf->msg[0] = mbx_opcode;
		resp_pf_to_vf->msg.code = mbx_opcode;

		memcpy(&resp_pf_to_vf->msg[1], msg, msg_len);
		memcpy(&resp_pf_to_vf->msg.vf_mbx_msg_code, msg, msg_len);

		status = hclge_cmd_send(&hdev->hw, &desc, 1);
		if (status)
		dev_err(&hdev->pdev->dev,
		"PF failed(=%d) to send mailbox message to VF\n",
		status);
		"failed to send mailbox to VF, status: %d, vfid: %u, opcode: %u\n",
		status, dest_vfid, mbx_opcode);

		return status;
		}
		@@ -152,21 +154,20 @@ static int hclge_get_ring_chain_from_mbx(
		{
		struct hnae3_ring_chain_node cur_chain, new_chain;
		int ring_num;
		int i;
		int i = 0;

		ring_num = req->msg[2];
		ring_num = req->msg.ring_num;

		if (ring_num > ((HCLGE_MBX_VF_MSG_DATA_NUM -
		HCLGE_MBX_RING_MAP_BASIC_MSG_NUM) /
		HCLGE_MBX_RING_NODE_VARIABLE_NUM))
		if (ring_num > HCLGE_MBX_MAX_RING_CHAIN_PARAM_NUM)
		return -ENOMEM;

		hnae3_set_bit(ring_chain->flag, HNAE3_RING_TYPE_B, req->msg[3]);
		hnae3_set_bit(ring_chain->flag, HNAE3_RING_TYPE_B,
		req->msg.param[i].ring_type);
		ring_chain->tqp_index =
		hclge_get_queue_id(vport->nic.kinfo.tqp[req->msg[4]]);
		hclge_get_queue_id(vport->nic.kinfo.tqp
		[req->msg.param[i].tqp_index]);
		hnae3_set_field(ring_chain->int_gl_idx, HNAE3_RING_GL_IDX_M,
		HNAE3_RING_GL_IDX_S,
		req->msg[5]);
		HNAE3_RING_GL_IDX_S, req->msg.param[i].int_gl_index);

		cur_chain = ring_chain;

		@@ -176,18 +177,15 @@ static int hclge_get_ring_chain_from_mbx(
		goto err;

		hnae3_set_bit(new_chain->flag, HNAE3_RING_TYPE_B,
		req->msg[HCLGE_MBX_RING_NODE_VARIABLE_NUM * i +
		HCLGE_MBX_RING_MAP_BASIC_MSG_NUM]);
		req->msg.param[i].ring_type);

		new_chain->tqp_index =
		hclge_get_queue_id(vport->nic.kinfo.tqp
		[req->msg[HCLGE_MBX_RING_NODE_VARIABLE_NUM * i +
		HCLGE_MBX_RING_MAP_BASIC_MSG_NUM + 1]]);
		[req->msg.param[i].tqp_index]);

		hnae3_set_field(new_chain->int_gl_idx, HNAE3_RING_GL_IDX_M,
		HNAE3_RING_GL_IDX_S,
		req->msg[HCLGE_MBX_RING_NODE_VARIABLE_NUM * i +
		HCLGE_MBX_RING_MAP_BASIC_MSG_NUM + 2]);
		req->msg.param[i].int_gl_index);

		cur_chain->next = new_chain;
		cur_chain = new_chain;
		@@ -203,7 +201,7 @@ static int hclge_map_unmap_ring_to_vf_vector(struct hclge_vport *vport, bool en,
		struct hclge_mbx_vf_to_pf_cmd *req)
		{
		struct hnae3_ring_chain_node ring_chain;
		int vector_id = req->msg[1];
		int vector_id = req->msg.vector_id;
		int ret;

		memset(&ring_chain, 0, sizeof(ring_chain));
		@@ -221,13 +219,9 @@ static int hclge_map_unmap_ring_to_vf_vector(struct hclge_vport *vport, bool en,
		static int hclge_set_vf_promisc_mode(struct hclge_vport *vport,
		struct hclge_mbx_vf_to_pf_cmd *req)
		{
		#define HCLGE_MBX_BC_INDEX 1
		#define HCLGE_MBX_UC_INDEX 2
		#define HCLGE_MBX_MC_INDEX 3

		bool en_bc = req->msg[HCLGE_MBX_BC_INDEX] ? true : false;
		bool en_uc = req->msg[HCLGE_MBX_UC_INDEX] ? true : false;
		bool en_mc = req->msg[HCLGE_MBX_MC_INDEX] ? true : false;
		bool en_bc = req->msg.en_bc ? true : false;
		bool en_uc = req->msg.en_uc ? true : false;
		bool en_mc = req->msg.en_mc ? true : false;
		int ret;

		if (!vport->vf_info.trusted) {
		@@ -258,12 +252,15 @@ void hclge_inform_vf_promisc_info(struct hclge_vport *vport)
		static int hclge_set_vf_uc_mac_addr(struct hclge_vport *vport,
		struct hclge_mbx_vf_to_pf_cmd *mbx_req)
		{
		const u8 mac_addr = (const u8 )(&mbx_req->msg[2]);
		#define HCLGE_MBX_VF_OLD_MAC_ADDR_OFFSET 6

		const u8 mac_addr = (const u8 )(mbx_req->msg.data);
		struct hclge_dev *hdev = vport->back;
		int status;

		if (mbx_req->msg[1] == HCLGE_MBX_MAC_VLAN_UC_MODIFY) {
		const u8 old_addr = (const u8 )(&mbx_req->msg[8]);
		if (mbx_req->msg.subcode == HCLGE_MBX_MAC_VLAN_UC_MODIFY) {
		const u8 old_addr = (const u8 )
		(&mbx_req->msg.data[HCLGE_MBX_VF_OLD_MAC_ADDR_OFFSET]);

		/* If VF MAC has been configured by the host then it
		* cannot be overridden by the MAC specified by the VM.
		@@ -289,12 +286,12 @@ static int hclge_set_vf_uc_mac_addr(struct hclge_vport *vport,
		hclge_add_vport_mac_table(vport, mac_addr,
		HCLGE_MAC_ADDR_UC);
		}
		} else if (mbx_req->msg[1] == HCLGE_MBX_MAC_VLAN_UC_ADD) {
		} else if (mbx_req->msg.subcode == HCLGE_MBX_MAC_VLAN_UC_ADD) {
		status = hclge_add_uc_addr_common(vport, mac_addr);
		if (!status)
		hclge_add_vport_mac_table(vport, mac_addr,
		HCLGE_MAC_ADDR_UC);
		} else if (mbx_req->msg[1] == HCLGE_MBX_MAC_VLAN_UC_REMOVE) {
		} else if (mbx_req->msg.subcode == HCLGE_MBX_MAC_VLAN_UC_REMOVE) {
		status = hclge_rm_uc_addr_common(vport, mac_addr);
		if (!status)
		hclge_rm_vport_mac_table(vport, mac_addr,
		@@ -302,7 +299,7 @@ static int hclge_set_vf_uc_mac_addr(struct hclge_vport *vport,
		} else {
		dev_err(&hdev->pdev->dev,
		"failed to set unicast mac addr, unknown subcode %u\n",
		mbx_req->msg[1]);
		mbx_req->msg.subcode);
		return -EIO;
		}

		@@ -317,18 +314,18 @@ static int hclge_set_vf_mc_mac_addr(struct hclge_vport *vport,
		struct hclge_mbx_vf_to_pf_cmd *mbx_req,
		bool gen_resp)
		{
		const u8 mac_addr = (const u8 )(&mbx_req->msg[2]);
		const u8 mac_addr = (const u8 )(mbx_req->msg.data);
		struct hclge_dev *hdev = vport->back;
		u8 resp_len = 0;
		u8 resp_data;
		int status;

		if (mbx_req->msg[1] == HCLGE_MBX_MAC_VLAN_MC_ADD) {
		if (mbx_req->msg.subcode == HCLGE_MBX_MAC_VLAN_MC_ADD) {
		status = hclge_add_mc_addr_common(vport, mac_addr);
		if (!status)
		hclge_add_vport_mac_table(vport, mac_addr,
		HCLGE_MAC_ADDR_MC);
		} else if (mbx_req->msg[1] == HCLGE_MBX_MAC_VLAN_MC_REMOVE) {
		} else if (mbx_req->msg.subcode == HCLGE_MBX_MAC_VLAN_MC_REMOVE) {
		status = hclge_rm_mc_addr_common(vport, mac_addr);
		if (!status)
		hclge_rm_vport_mac_table(vport, mac_addr,
		@@ -336,7 +333,7 @@ static int hclge_set_vf_mc_mac_addr(struct hclge_vport *vport,
		} else {
		dev_err(&hdev->pdev->dev,
		"failed to set mcast mac addr, unknown subcode %u\n",
		mbx_req->msg[1]);
		mbx_req->msg.subcode);
		return -EIO;
		}

		@@ -367,10 +364,13 @@ int hclge_push_vf_port_base_vlan_info(struct hclge_vport *vport, u8 vfid,
		static int hclge_set_vf_vlan_cfg(struct hclge_vport *vport,
		struct hclge_mbx_vf_to_pf_cmd *mbx_req)
		{
		#define HCLGE_MBX_VLAN_STATE_OFFSET 0
		#define HCLGE_MBX_VLAN_INFO_OFFSET 2

		struct hclge_vf_vlan_cfg *msg_cmd;
		int status = 0;

		msg_cmd = (struct hclge_vf_vlan_cfg *)mbx_req->msg;
		msg_cmd = (struct hclge_vf_vlan_cfg *)&mbx_req->msg;
		if (msg_cmd->subcode == HCLGE_MBX_VLAN_FILTER) {
		struct hnae3_handle *handle = &vport->nic;
		u16 vlan, proto;
		@@ -389,15 +389,16 @@ static int hclge_set_vf_vlan_cfg(struct hclge_vport *vport,
		bool en = msg_cmd->is_kill ? true : false;

		status = hclge_en_hw_strip_rxvtag(handle, en);
		} else if (mbx_req->msg[1] == HCLGE_MBX_PORT_BASE_VLAN_CFG) {
		} else if (msg_cmd->subcode == HCLGE_MBX_PORT_BASE_VLAN_CFG) {
		struct hclge_vlan_info *vlan_info;
		u16 *state;

		state = (u16 *)&mbx_req->msg[2];
		vlan_info = (struct hclge_vlan_info *)&mbx_req->msg[4];
		state = (u16 *)&mbx_req->msg.data[HCLGE_MBX_VLAN_STATE_OFFSET];
		vlan_info = (struct hclge_vlan_info *)
		&mbx_req->msg.data[HCLGE_MBX_VLAN_INFO_OFFSET];
		status = hclge_update_port_base_vlan_cfg(vport, *state,
		vlan_info);
		} else if (mbx_req->msg[1] == HCLGE_MBX_GET_PORT_BASE_VLAN_STATE) {
		} else if (msg_cmd->subcode == HCLGE_MBX_GET_PORT_BASE_VLAN_STATE) {
		u8 state;

		state = vport->port_base_vlan_cfg.state;
		@@ -412,7 +413,7 @@ static int hclge_set_vf_alive(struct hclge_vport *vport,
		struct hclge_mbx_vf_to_pf_cmd *mbx_req,
		bool gen_resp)
		{
		bool alive = !!mbx_req->msg[2];
		bool alive = !!mbx_req->msg.data[0];
		int ret = 0;

		if (alive)
		@@ -543,7 +544,7 @@ static void hclge_get_link_mode(struct hclge_vport *vport,
		advertising = hdev->hw.mac.advertising[0];
		supported = hdev->hw.mac.supported[0];
		dest_vfid = mbx_req->mbx_src_vfid;
		msg_data[0] = mbx_req->msg[2];
		msg_data[0] = mbx_req->msg.data[0];

		send_data = msg_data[0] == HCLGE_SUPPORTED ? supported : advertising;

		@@ -557,7 +558,7 @@ static void hclge_mbx_reset_vf_queue(struct hclge_vport *vport,
		{
		u16 queue_id;

		memcpy(&queue_id, &mbx_req->msg[2], sizeof(queue_id));
		memcpy(&queue_id, mbx_req->msg.data, sizeof(queue_id));

		hclge_reset_vf_queue(vport, queue_id);

		@@ -590,7 +591,7 @@ static int hclge_set_vf_mtu(struct hclge_vport *vport,
		int ret;
		u32 mtu;

		memcpy(&mtu, &mbx_req->msg[2], sizeof(mtu));
		memcpy(&mtu, mbx_req->msg.data, sizeof(mtu));
		ret = hclge_set_vport_mtu(vport, mtu);

		return hclge_gen_resp_to_vf(vport, mbx_req, ret, NULL, 0);
		@@ -602,7 +603,7 @@ static int hclge_get_queue_id_in_pf(struct hclge_vport *vport,
		u16 queue_id, qid_in_pf;
		u8 resp_data[2];

		memcpy(&queue_id, &mbx_req->msg[2], sizeof(queue_id));
		memcpy(&queue_id, mbx_req->msg.data, sizeof(queue_id));
		qid_in_pf = hclge_covert_handle_qid_global(&vport->nic, queue_id);
		memcpy(resp_data, &qid_in_pf, sizeof(qid_in_pf));

		@@ -618,7 +619,7 @@ static int hclge_get_rss_key(struct hclge_vport *vport,
		struct hclge_dev *hdev = vport->back;
		u8 index;

		index = mbx_req->msg[2];
		index = mbx_req->msg.data[0];

		memcpy(&resp_data[0],
		&hdev->vport[0].rss_hash_key[index * HCLGE_RSS_MBX_RESP_LEN],
		@@ -648,13 +649,10 @@ static void hclge_link_fail_parse(struct hclge_dev *hdev, u8 link_fail_code)
		static void hclge_handle_link_change_event(struct hclge_dev *hdev,
		struct hclge_mbx_vf_to_pf_cmd *req)
		{
		#define LINK_STATUS_OFFSET 1
		#define LINK_FAIL_CODE_OFFSET 2

		hclge_task_schedule(hdev, 0);

		if (!req->msg[LINK_STATUS_OFFSET])
		hclge_link_fail_parse(hdev, req->msg[LINK_FAIL_CODE_OFFSET]);
		if (!req->msg.subcode)
		hclge_link_fail_parse(hdev, req->msg.data[0]);
		}

		static bool hclge_cmd_crq_empty(struct hclge_hw *hw)
		@@ -697,7 +695,7 @@ void hclge_mbx_handler(struct hclge_dev *hdev)
		if (unlikely(!hnae3_get_bit(flag, HCLGE_CMDQ_RX_OUTVLD_B))) {
		dev_warn(&hdev->pdev->dev,
		"dropped invalid mailbox message, code = %u\n",
		req->msg[0]);
		req->msg.code);

		/* dropping/not processing this invalid message */
		crq->desc[crq->next_to_use].flag = 0;
		@@ -707,7 +705,7 @@ void hclge_mbx_handler(struct hclge_dev *hdev)

		vport = &hdev->vport[req->mbx_src_vfid];

		switch (req->msg[0]) {
		switch (req->msg.code) {
		case HCLGE_MBX_MAP_RING_TO_VECTOR:
		ret = hclge_map_unmap_ring_to_vf_vector(vport, true,
		req);
		@@ -843,7 +841,7 @@ void hclge_mbx_handler(struct hclge_dev *hdev)
		default:
		dev_err(&hdev->pdev->dev,
		"un-supported mailbox message, code = %u\n",
		req->msg[0]);
		req->msg.code);
		break;
		}
		crq->desc[crq->next_to_use].flag = 0;

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

+170 −141

File changed.

Preview size limit exceeded, changes collapsed.

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -305,8 +305,8 @@ static inline bool hclgevf_is_reset_pending(struct hclgevf_dev *hdev)
		return !!hdev->reset_pending;
		}

		int hclgevf_send_mbx_msg(struct hclgevf_dev *hdev, u16 code, u16 subcode,
		const u8 *msg_data, u8 msg_len, bool need_resp,
		int hclgevf_send_mbx_msg(struct hclgevf_dev *hdev,
		struct hclge_vf_to_pf_msg *send_msg, bool need_resp,
		u8 *resp_data, u16 resp_len);
		void hclgevf_mbx_handler(struct hclgevf_dev *hdev);
		void hclgevf_mbx_async_handler(struct hclgevf_dev *hdev);

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_mbx.c

+19 −21

Original line number	Diff line number	Diff line
		@@ -84,8 +84,8 @@ static int hclgevf_get_mbx_resp(struct hclgevf_dev *hdev, u16 code0, u16 code1,
		return 0;
		}

		int hclgevf_send_mbx_msg(struct hclgevf_dev *hdev, u16 code, u16 subcode,
		const u8 *msg_data, u8 msg_len, bool need_resp,
		int hclgevf_send_mbx_msg(struct hclgevf_dev *hdev,
		struct hclge_vf_to_pf_msg *send_msg, bool need_resp,
		u8 *resp_data, u16 resp_len)
		{
		struct hclge_mbx_vf_to_pf_cmd *req;
		@@ -94,21 +94,16 @@ int hclgevf_send_mbx_msg(struct hclgevf_dev *hdev, u16 code, u16 subcode,

		req = (struct hclge_mbx_vf_to_pf_cmd *)desc.data;

		/* first two bytes are reserved for code & subcode */
		if (msg_len > (HCLGE_MBX_MAX_MSG_SIZE - 2)) {
		if (!send_msg) {
		dev_err(&hdev->pdev->dev,
		"VF send mbx msg fail, msg len %d exceeds max len %d\n",
		msg_len, HCLGE_MBX_MAX_MSG_SIZE);
		"failed to send mbx, msg is NULL\n");
		return -EINVAL;
		}

		hclgevf_cmd_setup_basic_desc(&desc, HCLGEVF_OPC_MBX_VF_TO_PF, false);
		req->mbx_need_resp \|= need_resp ? HCLGE_MBX_NEED_RESP_BIT :
		~HCLGE_MBX_NEED_RESP_BIT;
		req->msg[0] = code;
		req->msg[1] = subcode;
		if (msg_data)
		memcpy(&req->msg[2], msg_data, msg_len);
		memcpy(&req->msg, send_msg, sizeof(struct hclge_vf_to_pf_msg));

		/* synchronous send */
		if (need_resp) {
		@@ -123,7 +118,8 @@ int hclgevf_send_mbx_msg(struct hclgevf_dev *hdev, u16 code, u16 subcode,
		return status;
		}

		status = hclgevf_get_mbx_resp(hdev, code, subcode, resp_data,
		status = hclgevf_get_mbx_resp(hdev, send_msg->code,
		send_msg->subcode, resp_data,
		resp_len);
		mutex_unlock(&hdev->mbx_resp.mbx_mutex);
		} else {
		@@ -174,7 +170,7 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
		if (unlikely(!hnae3_get_bit(flag, HCLGEVF_CMDQ_RX_OUTVLD_B))) {
		dev_warn(&hdev->pdev->dev,
		"dropped invalid mailbox message, code = %u\n",
		req->msg[0]);
		req->msg.code);

		/* dropping/not processing this invalid message */
		crq->desc[crq->next_to_use].flag = 0;
		@@ -188,19 +184,21 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
		* timeout and simultaneously queue the async messages for later
		* prcessing in context of mailbox task i.e. the slow path.
		*/
		switch (req->msg[0]) {
		switch (req->msg.code) {
		case HCLGE_MBX_PF_VF_RESP:
		if (resp->received_resp)
		dev_warn(&hdev->pdev->dev,
		"VF mbx resp flag not clear(%u)\n",
		req->msg[1]);
		req->msg.vf_mbx_msg_code);
		resp->received_resp = true;

		resp->origin_mbx_msg = (req->msg[1] << 16);
		resp->origin_mbx_msg \|= req->msg[2];
		resp->resp_status = hclgevf_resp_to_errno(req->msg[3]);
		resp->origin_mbx_msg =
		(req->msg.vf_mbx_msg_code << 16);
		resp->origin_mbx_msg \|= req->msg.vf_mbx_msg_subcode;
		resp->resp_status =
		hclgevf_resp_to_errno(req->msg.resp_status);

		temp = (u8 *)&req->msg[4];
		temp = (u8 *)req->msg.resp_data;
		for (i = 0; i < HCLGE_MBX_MAX_RESP_DATA_SIZE; i++) {
		resp->additional_info[i] = *temp;
		temp++;
		@@ -225,13 +223,13 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
		HCLGE_MBX_MAX_ARQ_MSG_NUM) {
		dev_warn(&hdev->pdev->dev,
		"Async Q full, dropping msg(%u)\n",
		req->msg[1]);
		req->msg.code);
		break;
		}

		/* tail the async message in arq */
		msg_q = hdev->arq.msg_q[hdev->arq.tail];
		memcpy(&msg_q[0], req->msg,
		memcpy(&msg_q[0], &req->msg,
		HCLGE_MBX_MAX_ARQ_MSG_SIZE * sizeof(u16));
		hclge_mbx_tail_ptr_move_arq(hdev->arq);
		atomic_inc(&hdev->arq.count);
		@@ -242,7 +240,7 @@ void hclgevf_mbx_handler(struct hclgevf_dev *hdev)
		default:
		dev_err(&hdev->pdev->dev,
		"VF received unsupported(%u) mbx msg from PF\n",
		req->msg[0]);
		req->msg.code);
		break;
		}
		crq->desc[crq->next_to_use].flag = 0;

Admin message